Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(recorder): do not reset inspect highlight on inactivity (#34526)

Browse source
This commit is contained in:
Pavel Feldman 2025-01-28 16:00:28 -08:00 committed by GitHub
parent 7060cd1bf7
commit 391e9c4de0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
packages/playwright-core/src/server/injected/recorder/pollingRecorder.ts
View file

@ -34,6 +34,7 @@ export class PollingRecorder implements RecorderDelegate {
private _recorder: Recorder; private _recorder: Recorder;
private _embedder: Embedder; private _embedder: Embedder;
private _pollRecorderModeTimer: number | undefined; private _pollRecorderModeTimer: number | undefined;
private _lastStateJSON: string | undefined;
constructor(injectedScript: InjectedScript) { constructor(injectedScript: InjectedScript) {
this._recorder = new Recorder(injectedScript); this._recorder = new Recorder(injectedScript);
@ -42,6 +43,7 @@ export class PollingRecorder implements RecorderDelegate {
injectedScript.onGlobalListenersRemoved.add(() => this._recorder.installListeners()); injectedScript.onGlobalListenersRemoved.add(() => this._recorder.installListeners());
const refreshOverlay = () => { const refreshOverlay = () => {
this._lastStateJSON = undefined;
this._pollRecorderMode().catch(e => console.log(e)); // eslint-disable-line no-console this._pollRecorderMode().catch(e => console.log(e)); // eslint-disable-line no-console
}; };
this._embedder.__pw_refreshOverlay = refreshOverlay; this._embedder.__pw_refreshOverlay = refreshOverlay;
@ -57,13 +59,19 @@ export class PollingRecorder implements RecorderDelegate {
this._pollRecorderModeTimer = this._recorder.injectedScript.builtinSetTimeout(() => this._pollRecorderMode(), pollPeriod); this._pollRecorderModeTimer = this._recorder.injectedScript.builtinSetTimeout(() => this._pollRecorderMode(), pollPeriod);
return; return;
} }
const win = this._recorder.document.defaultView!;
if (win.top !== win) { const stringifiedState = JSON.stringify(state);
// Only show action point in the main frame, since it is relative to the page's viewport. if (this._lastStateJSON !== stringifiedState) {
// Otherwise we'll see multiple action points at different locations. this._lastStateJSON = stringifiedState;
state.actionPoint = undefined; const win = this._recorder.document.defaultView!;
if (win.top !== win) {
// Only show action point in the main frame, since it is relative to the page's viewport.
// Otherwise we'll see multiple action points at different locations.
state.actionPoint = undefined;
}
this._recorder.setUIState(state, this);
} }
this._recorder.setUIState(state, this);
this._pollRecorderModeTimer = this._recorder.injectedScript.builtinSetTimeout(() => this._pollRecorderMode(), pollPeriod); this._pollRecorderModeTimer = this._recorder.injectedScript.builtinSetTimeout(() => this._pollRecorderMode(), pollPeriod);
} }