Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(testrunner): fit.fail should run the test (#1407)

Browse source
This commit is contained in:
Dmitry Gozman 2020-03-16 19:12:52 -07:00 committed by GitHub
parent aa32d351be
commit 3960b179a1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
utils/testrunner/TestRunner.js
View file

@ -207,7 +207,7 @@ class TestWorker {
return; return;
} }
if (test.expectation === TestExpectation.Fail) { if (test.expectation === TestExpectation.Fail && test.declaredMode !== TestMode.Focus) {
await this._testPass._willStartTest(this, test); await this._testPass._willStartTest(this, test);
test.result = TestResult.MarkedAsFailing; test.result = TestResult.MarkedAsFailing;
await this._testPass._didFinishTest(this, test); await this._testPass._didFinishTest(this, test);

9
utils/testrunner/test/testrunner.spec.js
View file

@ -49,6 +49,15 @@ module.exports.addTests = function({testRunner, expect}) {
expect(test.fullName).toBe('uno'); expect(test.fullName).toBe('uno');
expect(test.declaredMode).toBe('focus'); expect(test.declaredMode).toBe('focus');
}); });
it('should run a failed focused test', async() => {
const t = newTestRunner();
let run = false;
t.fit.fail(true)('uno', () => { run = true; throw new Error('failure'); });
expect(t.tests().length).toBe(1);
await t.run();
expect(run).toBe(true);
expect(t.failedTests()[0].name).toBe('uno');
});
}); });
describe('TestRunner.describe', () => { describe('TestRunner.describe', () => {