From 3a1eb2abda299eb14dc1c50cbd8971d4e6dd8492 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Fri, 13 Jan 2023 06:42:56 -0800 Subject: [PATCH] chore: fix racy emptyOutDir in trace-viewer build (#20090) --- packages/trace-viewer/vite.config.ts | 3 ++- packages/trace-viewer/vite.sw.config.ts | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/trace-viewer/vite.config.ts b/packages/trace-viewer/vite.config.ts index 0807316fc5..92080fe003 100644 --- a/packages/trace-viewer/vite.config.ts +++ b/packages/trace-viewer/vite.config.ts @@ -35,7 +35,8 @@ export default defineConfig({ }, build: { outDir: path.resolve(__dirname, '../playwright-core/lib/webpack/traceViewer'), - emptyOutDir: true, + // Output dir is shared with vite.sw.config.ts, clearing it here is racy. + emptyOutDir: false, rollupOptions: { output: { entryFileNames: () => '[name].[hash].js', diff --git a/packages/trace-viewer/vite.sw.config.ts b/packages/trace-viewer/vite.sw.config.ts index 8b23d6aac8..9929f5d205 100644 --- a/packages/trace-viewer/vite.sw.config.ts +++ b/packages/trace-viewer/vite.sw.config.ts @@ -35,6 +35,8 @@ export default defineConfig({ }, build: { outDir: path.resolve(__dirname, '../playwright-core/lib/webpack/traceViewer'), + // Output dir is shared with vite.config.ts, clearing it here is racy. + emptyOutDir: false, rollupOptions: { input: { sw: path.resolve(__dirname, 'src/sw.ts'),