From 3a64da7a54fe0b00706b6d0f83e01f1c3b13cd11 Mon Sep 17 00:00:00 2001
From: Max Schmitt <max@schmitt.mx>
Date: Thu, 11 Nov 2021 18:32:22 +0100
Subject: [PATCH] fix: do not show taskkill.exe output (#10244)

---
 packages/playwright-core/src/utils/processLauncher.ts | 8 ++++++--
 tests/config/commonFixtures.ts                        | 2 +-
 tests/signals.spec.ts                                 | 2 +-
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/packages/playwright-core/src/utils/processLauncher.ts b/packages/playwright-core/src/utils/processLauncher.ts
index 5459340b39..79dc2e8d4a 100644
--- a/packages/playwright-core/src/utils/processLauncher.ts
+++ b/packages/playwright-core/src/utils/processLauncher.ts
@@ -172,8 +172,12 @@ export async function launchProcess(options: LaunchProcessOptions): Promise<Laun
       // Force kill the browser.
       try {
         if (process.platform === 'win32') {
-          const stdout = childProcess.execSync(`taskkill /pid ${spawnedProcess.pid} /T /F /FI "MEMUSAGE gt 0"`);
-          options.log(`[pid=${spawnedProcess.pid}] taskkill output: ${stdout.toString()}`);
+          const taskkillProcess = childProcess.spawnSync(`taskkill /pid ${spawnedProcess.pid} /T /F /FI "MEMUSAGE gt 0"`, { shell: true });
+          const [stderr, stdout] = [taskkillProcess.stdout.toString(), taskkillProcess.stderr.toString()];
+          if (stdout)
+            options.log(`[pid=${spawnedProcess.pid}] taskkill stdout: ${stdout}`);
+          if (stderr)
+            options.log(`[pid=${spawnedProcess.pid}] taskkill stderr: ${stderr}`);
         } else {
           process.kill(-spawnedProcess.pid, 'SIGKILL');
         }
diff --git a/tests/config/commonFixtures.ts b/tests/config/commonFixtures.ts
index 86e70bc8fe..e6d2661e51 100644
--- a/tests/config/commonFixtures.ts
+++ b/tests/config/commonFixtures.ts
@@ -87,7 +87,7 @@ export class TestChildProcess {
       return;
     try {
       if (process.platform === 'win32')
-        execSync(`taskkill /pid ${this.process.pid} /T /F /FI "MEMUSAGE gt 0"`);
+        execSync(`taskkill /pid ${this.process.pid} /T /F /FI "MEMUSAGE gt 0"`, { stdio: 'ignore' });
       else
         process.kill(-this.process.pid, 'SIGKILL');
     } catch (e) {
diff --git a/tests/signals.spec.ts b/tests/signals.spec.ts
index 32225ade76..fb59bc182c 100644
--- a/tests/signals.spec.ts
+++ b/tests/signals.spec.ts
@@ -23,7 +23,7 @@ test.slow();
 test('should close the browser when the node process closes', async ({ startRemoteServer, isWindows, server }) => {
   const remoteServer = await startRemoteServer({ url: server.EMPTY_PAGE });
   if (isWindows)
-    execSync(`taskkill /pid ${remoteServer.child().pid} /T /F`);
+    execSync(`taskkill /pid ${remoteServer.child().pid} /T /F`, { stdio: 'ignore' });
   else
     process.kill(remoteServer.child().pid);
   // We might not get browser exitCode in time when killing the parent node process,