From 3afaeef5576f42695b90eb5eba982b1678c89d6e Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Wed, 26 Feb 2020 11:01:01 -0800 Subject: [PATCH] feat(socket): destroy contexts upon disconnect (#1119) --- src/chromium/crBrowser.ts | 2 +- src/firefox/ffBrowser.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/chromium/crBrowser.ts b/src/chromium/crBrowser.ts index fae047e520..37e85f163b 100644 --- a/src/chromium/crBrowser.ts +++ b/src/chromium/crBrowser.ts @@ -68,7 +68,7 @@ export class CRBrowser extends platform.EventEmitter implements Browser { async newContext(options: BrowserContextOptions = {}): Promise { options = validateBrowserContextOptions(options); - const { browserContextId } = await this._client.send('Target.createBrowserContext'); + const { browserContextId } = await this._client.send('Target.createBrowserContext', { disposeOnDetach: true }); const context = new CRBrowserContext(this, browserContextId, options); await context._initialize(); this._contexts.set(browserContextId, context); diff --git a/src/firefox/ffBrowser.ts b/src/firefox/ffBrowser.ts index e3141753c4..8af9ff804c 100644 --- a/src/firefox/ffBrowser.ts +++ b/src/firefox/ffBrowser.ts @@ -90,6 +90,7 @@ export class FFBrowser extends platform.EventEmitter implements Browser { bypassCSP: options.bypassCSP, javaScriptDisabled: options.javaScriptEnabled === false ? true : undefined, viewport, + removeOnDetach: true }); // TODO: move ignoreHTTPSErrors to browser context level. if (options.ignoreHTTPSErrors)