Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

devops: support --full argument for chromium compilation (#9965)

Browse source 
Like our other browser build scripts, chromium build now supports
`--full` flag to install all the required dependencies.
This commit is contained in:
Andrey Lushnikov 2021-11-02 03:23:15 -07:00 committed by GitHub
parent d91d58cbec
commit 3b545b86bc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
browser_patches/checkout_build_archive_upload.sh
View file

@ -78,34 +78,34 @@ elif [[ "$BUILD_FLAVOR" == "ffmpeg-cross-compile-win64" ]]; then
# =========================== # ===========================
elif [[ "$BUILD_FLAVOR" == "chromium-win64" ]]; then elif [[ "$BUILD_FLAVOR" == "chromium-win64" ]]; then
BROWSER_NAME="chromium" BROWSER_NAME="chromium"
EXTRA_BUILD_ARGS="--compile-win64" EXTRA_BUILD_ARGS="--compile-win64 --full"
EXTRA_ARCHIVE_ARGS="--compile-win64" EXTRA_ARCHIVE_ARGS="--compile-win64"
EXPECTED_HOST_OS="MINGW" EXPECTED_HOST_OS="MINGW"
BUILD_BLOB_NAME="chromium-win64.zip" BUILD_BLOB_NAME="chromium-win64.zip"
elif [[ "$BUILD_FLAVOR" == "chromium-mac" ]]; then elif [[ "$BUILD_FLAVOR" == "chromium-mac" ]]; then
BROWSER_NAME="chromium" BROWSER_NAME="chromium"
EXTRA_BUILD_ARGS="--compile-mac" EXTRA_BUILD_ARGS="--compile-mac --full"
EXTRA_ARCHIVE_ARGS="--compile-mac" EXTRA_ARCHIVE_ARGS="--compile-mac"
EXPECTED_HOST_OS="Darwin" EXPECTED_HOST_OS="Darwin"
EXPECTED_HOST_OS_VERSION="10.15" EXPECTED_HOST_OS_VERSION="10.15"
BUILD_BLOB_NAME="chromium-mac.zip" BUILD_BLOB_NAME="chromium-mac.zip"
elif [[ "$BUILD_FLAVOR" == "chromium-mac-arm64" ]]; then elif [[ "$BUILD_FLAVOR" == "chromium-mac-arm64" ]]; then
BROWSER_NAME="chromium" BROWSER_NAME="chromium"
EXTRA_BUILD_ARGS="--compile-mac-arm64" EXTRA_BUILD_ARGS="--compile-mac-arm64 --full"
EXTRA_ARCHIVE_ARGS="--compile-mac-arm64" EXTRA_ARCHIVE_ARGS="--compile-mac-arm64"
EXPECTED_HOST_OS="Darwin" EXPECTED_HOST_OS="Darwin"
EXPECTED_HOST_OS_VERSION="10.15" EXPECTED_HOST_OS_VERSION="10.15"
BUILD_BLOB_NAME="chromium-mac-arm64.zip" BUILD_BLOB_NAME="chromium-mac-arm64.zip"
elif [[ "$BUILD_FLAVOR" == "chromium-linux" ]]; then elif [[ "$BUILD_FLAVOR" == "chromium-linux" ]]; then
BROWSER_NAME="chromium" BROWSER_NAME="chromium"
EXTRA_BUILD_ARGS="--compile-linux" EXTRA_BUILD_ARGS="--compile-linux --full"
EXTRA_ARCHIVE_ARGS="--compile-linux" EXTRA_ARCHIVE_ARGS="--compile-linux"
EXPECTED_HOST_OS="Ubuntu" EXPECTED_HOST_OS="Ubuntu"
EXPECTED_HOST_OS_VERSION="18.04" EXPECTED_HOST_OS_VERSION="18.04"
BUILD_BLOB_NAME="chromium-linux.zip" BUILD_BLOB_NAME="chromium-linux.zip"
elif [[ "$BUILD_FLAVOR" == "chromium-linux-arm64" ]]; then elif [[ "$BUILD_FLAVOR" == "chromium-linux-arm64" ]]; then
BROWSER_NAME="chromium" BROWSER_NAME="chromium"
EXTRA_BUILD_ARGS="--compile-linux-arm64" EXTRA_BUILD_ARGS="--compile-linux-arm64 --full"
EXTRA_ARCHIVE_ARGS="--compile-linux-arm64" EXTRA_ARCHIVE_ARGS="--compile-linux-arm64"
EXPECTED_HOST_OS="Ubuntu" EXPECTED_HOST_OS="Ubuntu"
EXPECTED_HOST_OS_VERSION="20.04" EXPECTED_HOST_OS_VERSION="20.04"
@ -117,7 +117,7 @@ elif [[ "$BUILD_FLAVOR" == "chromium-linux-arm64" ]]; then
elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-win64" ]]; then elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-win64" ]]; then
BROWSER_NAME="chromium" BROWSER_NAME="chromium"
BROWSER_DISPLAY_NAME="chromium-with-symbols" BROWSER_DISPLAY_NAME="chromium-with-symbols"
EXTRA_BUILD_ARGS="--compile-win64 --symbols" EXTRA_BUILD_ARGS="--compile-win64 --symbols --full"
EXTRA_ARCHIVE_ARGS="--compile-win64" EXTRA_ARCHIVE_ARGS="--compile-win64"
EXPECTED_HOST_OS="MINGW" EXPECTED_HOST_OS="MINGW"
BUILD_BLOB_NAME="chromium-with-symbols-win64.zip" BUILD_BLOB_NAME="chromium-with-symbols-win64.zip"
@ -125,7 +125,7 @@ elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-win64" ]]; then
elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-mac" ]]; then elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-mac" ]]; then
BROWSER_NAME="chromium" BROWSER_NAME="chromium"
BROWSER_DISPLAY_NAME="chromium-with-symbols" BROWSER_DISPLAY_NAME="chromium-with-symbols"
EXTRA_BUILD_ARGS="--compile-mac --symbols" EXTRA_BUILD_ARGS="--compile-mac --symbols --full"
EXTRA_ARCHIVE_ARGS="--compile-mac" EXTRA_ARCHIVE_ARGS="--compile-mac"
EXPECTED_HOST_OS="Darwin" EXPECTED_HOST_OS="Darwin"
EXPECTED_HOST_OS_VERSION="10.15" EXPECTED_HOST_OS_VERSION="10.15"
@ -134,7 +134,7 @@ elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-mac" ]]; then
elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-mac-arm64" ]]; then elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-mac-arm64" ]]; then
BROWSER_NAME="chromium" BROWSER_NAME="chromium"
BROWSER_DISPLAY_NAME="chromium-with-symbols" BROWSER_DISPLAY_NAME="chromium-with-symbols"
EXTRA_BUILD_ARGS="--compile-mac-arm64 --symbols" EXTRA_BUILD_ARGS="--compile-mac-arm64 --symbols --full"
EXTRA_ARCHIVE_ARGS="--compile-mac-arm64" EXTRA_ARCHIVE_ARGS="--compile-mac-arm64"
EXPECTED_HOST_OS="Darwin" EXPECTED_HOST_OS="Darwin"
EXPECTED_HOST_OS_VERSION="10.15" EXPECTED_HOST_OS_VERSION="10.15"
@ -143,7 +143,7 @@ elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-mac-arm64" ]]; then
elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-linux" ]]; then elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-linux" ]]; then
BROWSER_NAME="chromium" BROWSER_NAME="chromium"
BROWSER_DISPLAY_NAME="chromium-with-symbols" BROWSER_DISPLAY_NAME="chromium-with-symbols"
EXTRA_BUILD_ARGS="--compile-linux --symbols" EXTRA_BUILD_ARGS="--compile-linux --symbols --full"
EXTRA_ARCHIVE_ARGS="--compile-linux" EXTRA_ARCHIVE_ARGS="--compile-linux"
EXPECTED_HOST_OS="Ubuntu" EXPECTED_HOST_OS="Ubuntu"
EXPECTED_HOST_OS_VERSION="18.04" EXPECTED_HOST_OS_VERSION="18.04"
@ -152,7 +152,7 @@ elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-linux" ]]; then
elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-linux-arm64" ]]; then elif [[ "$BUILD_FLAVOR" == "chromium-with-symbols-linux-arm64" ]]; then
BROWSER_NAME="chromium" BROWSER_NAME="chromium"
BROWSER_DISPLAY_NAME="chromium-with-symbols-arm64" BROWSER_DISPLAY_NAME="chromium-with-symbols-arm64"
EXTRA_BUILD_ARGS="--compile-linux-arm64 --symbols" EXTRA_BUILD_ARGS="--compile-linux-arm64 --symbols --full"
EXTRA_ARCHIVE_ARGS="--compile-linux-arm64" EXTRA_ARCHIVE_ARGS="--compile-linux-arm64"
EXPECTED_HOST_OS="Ubuntu" EXPECTED_HOST_OS="Ubuntu"
EXPECTED_HOST_OS_VERSION="20.04" EXPECTED_HOST_OS_VERSION="20.04"

17
browser_patches/chromium/build.sh
View file

@ -6,7 +6,7 @@ trap "cd $(pwd -P)" EXIT
cd "$(dirname "$0")" cd "$(dirname "$0")"
USAGE=$(cat<<EOF USAGE=$(cat<<EOF
usage: $(basename "$0") [--mirror|--mirror-linux|--mirror-win64|--mirror-mac|--compile-mac-arm64|--compile-linux|--compile-linux-arm64|--compile-win64|--compile-mac] usage: $(basename "$0") [--mirror|--mirror-linux|--mirror-win64|--mirror-mac|--compile-mac-arm64|--compile-linux|--compile-linux-arm64|--compile-win64|--compile-mac] [--symbols] [--full]
Either compiles chromium or mirrors it from Chromium Continuous Builds CDN. Either compiles chromium or mirrors it from Chromium Continuous Builds CDN.
EOF EOF
@ -22,7 +22,7 @@ main() {
elif [[ $1 == "--mirror"* ]]; then elif [[ $1 == "--mirror"* ]]; then
mirror_chromium "$1" mirror_chromium "$1"
elif [[ $1 == "--compile"* ]]; then elif [[ $1 == "--compile"* ]]; then
compile_chromium "$1" compile_chromium "$1" "$2" "$3"
else else
echo "ERROR: unknown first argument. Use --help for details." echo "ERROR: unknown first argument. Use --help for details."
exit 1 exit 1
@ -59,7 +59,7 @@ compile_chromium() {
mkdir -p "./out/Default" mkdir -p "./out/Default"
echo "is_debug = false" > ./out/Default/args.gn echo "is_debug = false" > ./out/Default/args.gn
echo "dcheck_always_on = false" >> ./out/Default/args.gn echo "dcheck_always_on = false" >> ./out/Default/args.gn
if [[ $2 == "--symbols" ]]; then if [[ $2 == "--symbols" || $3 == "--symbols" ]]; then
echo "symbol_level = 1" >> ./out/Default/args.gn echo "symbol_level = 1" >> ./out/Default/args.gn
else else
echo "symbol_level = 0" >> ./out/Default/args.gn echo "symbol_level = 0" >> ./out/Default/args.gn
@ -84,9 +84,14 @@ compile_chromium() {
cat ./out/Default/args.gn cat ./out/Default/args.gn
echo "===== ======= =====" echo "===== ======= ====="
if [[ $1 == "--compile-linux-arm64" ]]; then if [[ $2 == "--full" || $3 == "--full" ]]; then
# Install sysroot image, see https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/linux/chromium_arm.md if [[ $(uname) == "--compile-linux" ]]; then
./build/linux/sysroot_scripts/install-sysroot.py --arch=arm ./build/install-build-deps.sh
elif [[ $1 == "--compile-linux-arm64" ]]; then
./build/install-build-deps.sh --arm
# Install sysroot image, see https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/linux/chromium_arm.md
./build/linux/sysroot_scripts/install-sysroot.py --arch=arm
fi
fi fi
if [[ $1 == "--compile-win"* ]]; then if [[ $1 == "--compile-win"* ]]; then

2
browser_patches/prepare_checkout.sh
View file

@ -52,7 +52,7 @@ function prepare_chromium_checkout {
fetch --nohooks chromium fetch --nohooks chromium
cd src cd src
if [[ $(uname) == "Linux" ]]; then if [[ $(uname) == "Linux" ]]; then
./build/install-build-deps.sh --arm ./build/install-build-deps.sh
fi fi
gclient runhooks gclient runhooks
fi fi