Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: do not crash upon download in unknown page (#22774)

Browse source 
Fixes #22551.
This commit is contained in:
Dmitry Gozman 2023-05-02 18:49:04 -07:00 committed by GitHub
parent dee0f2791e
commit 3c724c2498
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/playwright-core/src/server/chromium/crBrowser.ts
View file

@ -243,7 +243,12 @@ export class CRBrowser extends Browser {
_onDownloadWillBegin(payload: Protocol.Browser.downloadWillBeginPayload) { _onDownloadWillBegin(payload: Protocol.Browser.downloadWillBeginPayload) {
const page = this._findOwningPage(payload.frameId); const page = this._findOwningPage(payload.frameId);
assert(page, 'Download started in unknown page: ' + JSON.stringify(payload)); if (!page) {
// There might be no page when download originates from something unusual, like
// a DevTools window or maybe an extension page.
// See https://github.com/microsoft/playwright/issues/22551.
return;
}
page.willBeginDownload(); page.willBeginDownload();
let originPage = page._initializedPage; let originPage = page._initializedPage;

3
packages/playwright-core/src/server/firefox/ffBrowser.ts
View file

@ -118,8 +118,7 @@ export class FFBrowser extends Browser {
} }
_onDownloadCreated(payload: Protocol.Browser.downloadCreatedPayload) { _onDownloadCreated(payload: Protocol.Browser.downloadCreatedPayload) {
const ffPage = this._ffPages.get(payload.pageTargetId)!; const ffPage = this._ffPages.get(payload.pageTargetId);
assert(ffPage);
if (!ffPage) if (!ffPage)
return; return;