Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

browser(firefox): fix redirect interception (#2672)

Browse source 
We sometimes receive shouldIntercept for redirects,
and should not issue sendOnRequest for the second time.
This commit is contained in:
Dmitry Gozman 2020-06-22 15:57:05 -07:00 committed by GitHub
parent bb34418095
commit 3d49af2537
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
browser_patches/firefox/BUILD_NUMBER
View file

@ -1 +1 @@
1114 1115

10
browser_patches/firefox/juggler/NetworkObserver.js
View file

@ -320,6 +320,12 @@ class NetworkRequest {
return false; return false;
} }
// We do not want to intercept any redirects, because we are not able
// to intercept subresource redirects, and it's unreliable for main requests.
// We do not sendOnRequest here, because redirects do that in constructor.
if (this.redirectedFromId)
return false;
const shouldIntercept = this._shouldIntercept(); const shouldIntercept = this._shouldIntercept();
if (!shouldIntercept) { if (!shouldIntercept) {
// We are not intercepting - ready to issue onRequest. // We are not intercepting - ready to issue onRequest.
@ -424,10 +430,6 @@ class NetworkRequest {
} }
_shouldIntercept() { _shouldIntercept() {
// We do not want to intercept any redirects, because we are not able
// to intercept subresource redirects.
if (this.redirectedFromId)
return false;
const pageNetwork = this._activePageNetwork(); const pageNetwork = this._activePageNetwork();
if (!pageNetwork) if (!pageNetwork)
return false; return false;