From 3d89657695b2d66feda007bd8cbbdd0b51cc7463 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Thu, 23 Jan 2025 15:55:41 +0100 Subject: [PATCH] remove get-free-port --- packages/playwright/src/index.ts | 5 +++-- packages/playwright/src/util.ts | 12 ------------ 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/packages/playwright/src/index.ts b/packages/playwright/src/index.ts index d8225ef077..01b6b549aa 100644 --- a/packages/playwright/src/index.ts +++ b/packages/playwright/src/index.ts @@ -130,8 +130,9 @@ const playwrightFixtures: Fixtures = ({ if (typeof mockingProxyOption.port === 'number' && testInfoImpl.config.workers > 1) throw new Error(`Cannot share mocking proxy between multiple workers. Either disable parallel mode or set mockingProxy.port to 'inject'`); - const port = typeof mockingProxyOption.port === 'number' ? mockingProxyOption.port : await getFreePort(); - const mockingProxy = await playwright.mockingProxy.newProxy(port); + const mockingProxy = await playwright.mockingProxy.newProxy( + mockingProxyOption.port === 'inject' ? undefined : mockingProxyOption.port + ); await use(mockingProxy); }, { scope: 'worker' }], diff --git a/packages/playwright/src/util.ts b/packages/playwright/src/util.ts index 23dea04d10..cd12895f91 100644 --- a/packages/playwright/src/util.ts +++ b/packages/playwright/src/util.ts @@ -398,15 +398,3 @@ export async function removeDirAndLogToConsole(dir: string) { } catch { } } - -export async function getFreePort() { - const promise = new ManualPromise(); - const server = net.createServer(); - server.unref(); - server.on('error', promise.reject); - server.listen(0, () => { - const { port } = server.address() as AddressInfo; - server.close(() => promise.resolve(port)); - }); - return promise; -}