Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: fix debug controller tests on firefox (#18361)

Browse source
This commit is contained in:
Pavel Feldman 2022-10-27 09:19:55 -07:00 committed by GitHub
parent 041a98928b
commit 3e112193a6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
tests/library/debug-controller.spec.ts
View file

@ -40,14 +40,14 @@ const test = baseTest.extend<Fixtures>({
await use(backend); await use(backend);
await backend.close(); await backend.close();
}, },
connectedBrowser: async ({ playwright, wsEndpoint }, use) => { connectedBrowser: async ({ wsEndpoint, browserType }, use) => {
const oldValue = (playwright.chromium as any)._defaultConnectOptions; const oldValue = (browserType as any)._defaultConnectOptions;
(playwright.chromium as any)._defaultConnectOptions = { (browserType as any)._defaultConnectOptions = {
wsEndpoint, wsEndpoint,
headers: { 'x-playwright-reuse-context': '1', }, headers: { 'x-playwright-reuse-context': '1', },
}; };
const browser = await playwright.chromium.launch(); const browser = await browserType.launch();
(playwright.chromium as any)._defaultConnectOptions = oldValue; (browserType as any)._defaultConnectOptions = oldValue;
await use(browser as any); await use(browser as any);
await browser.close(); await browser.close();
}, },
@ -64,16 +64,17 @@ test('should pick element', async ({ backend, connectedBrowser }) => {
const context = await connectedBrowser._newContextForReuse(); const context = await connectedBrowser._newContextForReuse();
const [page] = context.pages(); const [page] = context.pages();
await page.locator('body').click(); await page.setContent('<button>Submit</button>');
await page.locator('body').click(); await page.getByRole('button').click();
await page.getByRole('button').click();
expect(events).toEqual([ expect(events).toEqual([
{ {
selector: 'body', selector: 'internal:role=button[name=\"Submit\"]',
locator: 'locator(\'body\')', locator: 'getByRole(\'button\', { name: \'Submit\' })',
}, { }, {
selector: 'body', selector: 'internal:role=button[name=\"Submit\"]',
locator: 'locator(\'body\')', locator: 'getByRole(\'button\', { name: \'Submit\' })',
}, },
]); ]);
@ -156,19 +157,20 @@ test('should record', async ({ backend, connectedBrowser }) => {
const context = await connectedBrowser._newContextForReuse(); const context = await connectedBrowser._newContextForReuse();
const [page] = context.pages(); const [page] = context.pages();
await page.locator('body').click(); await page.setContent('<button>Submit</button>');
await page.getByRole('button').click();
await expect.poll(() => events[events.length - 1]).toEqual({ await expect.poll(() => events[events.length - 1]).toEqual({
text: `import { test, expect } from '@playwright/test'; text: `import { test, expect } from '@playwright/test';
test('test', async ({ page }) => { test('test', async ({ page }) => {
await page.goto('about:blank'); await page.goto('about:blank');
await page.locator('body').click(); await page.getByRole('button', { name: 'Submit' }).click();
});` });`
}); });
const length = events.length; const length = events.length;
// No events after mode disabled // No events after mode disabled
await backend.setMode({ mode: 'none' }); await backend.setMode({ mode: 'none' });
await page.locator('body').click(); await page.getByRole('button').click();
expect(events).toHaveLength(length); expect(events).toHaveLength(length);
}); });