From 3eb21e23220a2fd6a4472573144075154bdc6a1e Mon Sep 17 00:00:00 2001
From: Pavel Feldman <pavel.feldman@gmail.com>
Date: Wed, 14 Jul 2021 18:43:51 -0700
Subject: [PATCH] feat(webkit): roll to r1515 (#7625)

---
 browsers.json                   | 2 +-
 src/server/webkit/protocol.d.ts | 2 +-
 src/server/webkit/wkPage.ts     | 1 +
 tests/tracing.spec.ts           | 4 ++--
 utils/testserver/index.d.ts     | 4 ++--
 5 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/browsers.json b/browsers.json
index 52e4eb2ad9..5e500a2777 100644
--- a/browsers.json
+++ b/browsers.json
@@ -23,7 +23,7 @@
     },
     {
       "name": "webkit",
-      "revision": "1507",
+      "revision": "1515",
       "installByDefault": true,
       "revisionOverrides": {
         "mac10.14": "1446"
diff --git a/src/server/webkit/protocol.d.ts b/src/server/webkit/protocol.d.ts
index 940bb06862..6e5bbb1bd8 100644
--- a/src/server/webkit/protocol.d.ts
+++ b/src/server/webkit/protocol.d.ts
@@ -5990,7 +5990,7 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the
     /**
      * List of settings able to be overridden by WebInspector.
      */
-    export type Setting = "PrivateClickMeasurementDebugModeEnabled"|"AuthorAndUserStylesEnabled"|"ICECandidateFilteringEnabled"|"ITPDebugModeEnabled"|"ImagesEnabled"|"MediaCaptureRequiresSecureConnection"|"MockCaptureDevicesEnabled"|"NeedsSiteSpecificQuirks"|"ScriptEnabled"|"ShowDebugBorders"|"ShowRepaintCounter"|"WebRTCEncryptionEnabled"|"WebSecurityEnabled";
+    export type Setting = "PrivateClickMeasurementDebugModeEnabled"|"AuthorAndUserStylesEnabled"|"ICECandidateFilteringEnabled"|"ITPDebugModeEnabled"|"ImagesEnabled"|"MediaCaptureRequiresSecureConnection"|"MockCaptureDevicesEnabled"|"NeedsSiteSpecificQuirks"|"ScriptEnabled"|"ShowDebugBorders"|"ShowRepaintCounter"|"WebRTCEncryptionEnabled"|"WebSecurityEnabled"|"DeviceOrientationEventEnabled"|"SpeechRecognitionEnabled";
     /**
      * Resource type as it was perceived by the rendering engine.
      */
diff --git a/src/server/webkit/wkPage.ts b/src/server/webkit/wkPage.ts
index 15771b6011..008e8dac8a 100644
--- a/src/server/webkit/wkPage.ts
+++ b/src/server/webkit/wkPage.ts
@@ -209,6 +209,7 @@ export class WKPage implements PageDelegate {
       promises.push(session.send('Page.setTimeZone', { timeZone: contextOptions.timezoneId }).
           catch(e => { throw new Error(`Invalid timezone ID: ${contextOptions.timezoneId}`); }));
     }
+    promises.push(session.send('Page.overrideSetting', { setting: 'DeviceOrientationEventEnabled' as any, value: contextOptions.isMobile }));
     await Promise.all(promises);
   }
 
diff --git a/tests/tracing.spec.ts b/tests/tracing.spec.ts
index 6d4fcf0395..ee40dbb54f 100644
--- a/tests/tracing.spec.ts
+++ b/tests/tracing.spec.ts
@@ -19,7 +19,7 @@ import yauzl from 'yauzl';
 import jpeg from 'jpeg-js';
 
 test('should collect trace', async ({ context, page, server }, testInfo) => {
-  await context.tracing.start({ name: 'test', screenshots: true, snapshots: true });
+  await context.tracing.start({ screenshots: true, snapshots: true });
   await page.goto(server.EMPTY_PAGE);
   await page.setContent('<button>Click</button>');
   await page.click('"Click"');
@@ -182,7 +182,7 @@ for (const params of [
 }
 
 test('should include interrupted actions', async ({ context, page, server }, testInfo) => {
-  await context.tracing.start({ name: 'test', screenshots: true, snapshots: true });
+  await context.tracing.start({ screenshots: true, snapshots: true });
   await page.goto(server.EMPTY_PAGE);
   await page.setContent('<button>Click</button>');
   page.click('"ClickNoButton"').catch(() =>  {});
diff --git a/utils/testserver/index.d.ts b/utils/testserver/index.d.ts
index b37fb23db2..f495ecb44f 100644
--- a/utils/testserver/index.d.ts
+++ b/utils/testserver/index.d.ts
@@ -25,9 +25,9 @@ export class TestServer {
   enableGzip(path: string);
   setCSP(path: string, csp: string);
   stop(): Promise<void>;
-  setRoute(path: string, handler: (message: IncomingMessage & {postBody: Buffer}, response: ServerResponse) => void);
+  setRoute(path: string, handler: (message: IncomingMessage & { postBody: Promise<Buffer> }, response: ServerResponse) => void);
   setRedirect(from: string, to: string);
-  waitForRequest(path: string): Promise<IncomingMessage & {postBody: Buffer}>;
+  waitForRequest(path: string): Promise<IncomingMessage & { postBody: Promise<Buffer> }>;
   waitForWebSocketConnectionRequest(): Promise<IncomingMessage>;
   sendOnWebSocketConnection(data: string);
   reset();