From 3f79786cf87882326ef3737c405f404860fdd05c Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Thu, 19 Jan 2023 09:10:42 -0800 Subject: [PATCH] test: fix socks proxy test for wk mac (#20227) Drive-by: unskip firefox test. --- tests/library/browsertype-connect.spec.ts | 6 +++--- tests/library/defaultbrowsercontext-2.spec.ts | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/library/browsertype-connect.spec.ts b/tests/library/browsertype-connect.spec.ts index a5ab14b691..c83cf9c278 100644 --- a/tests/library/browsertype-connect.spec.ts +++ b/tests/library/browsertype-connect.spec.ts @@ -825,16 +825,16 @@ for (const kind of ['launchServer', 'run-server'] as const) { }); const remoteServer = await startRemoteServer(kind); const browser = await connect(remoteServer.wsEndpoint(), { - _exposeNetwork: 'localhost', + _exposeNetwork: '127.0.0.1', headers: { 'x-playwright-proxy': '*', }, } as any, dummyServerPort); const page = await browser.newPage(); - // 127.0.0.1 should fail on the client side. + // local.playwright should fail on the client side. let failed = false; - await page.goto(`http://127.0.0.1:${server.PORT}/foo.html`).catch(e => { + await page.goto(`http://local.playwright:${server.PORT}/foo.html`).catch(e => { failed = true; }); expect(failed).toBe(true); diff --git a/tests/library/defaultbrowsercontext-2.spec.ts b/tests/library/defaultbrowsercontext-2.spec.ts index 06fed51e38..4babd8e278 100644 --- a/tests/library/defaultbrowsercontext-2.spec.ts +++ b/tests/library/defaultbrowsercontext-2.spec.ts @@ -96,7 +96,6 @@ it('should accept userDataDir', async ({ createUserDataDir, browserType }) => { }); it('should restore state from userDataDir', async ({ browserType, server, createUserDataDir, isMac, browserName }) => { - it.fixme(browserName === 'firefox', 'https://github.com/microsoft/playwright/issues/12632'); it.slow(); const userDataDir = await createUserDataDir();