Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(tracing): record available response headers without waiting for extra info (#23483)

Browse source 
Fixes #23115
This commit is contained in:
Yury Semikhatsky 2023-06-02 14:15:20 -07:00 committed by GitHub
parent dd3ca6907a
commit 401fc4cb9e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
packages/playwright-core/src/server/har/harTracer.ts
View file

@ -478,18 +478,26 @@ export class HarTracer {
this._addBarrier(page || request.serviceWorker(), request.rawRequestHeaders().then(headers => { this._addBarrier(page || request.serviceWorker(), request.rawRequestHeaders().then(headers => {
this._recordRequestHeadersAndCookies(harEntry, headers); this._recordRequestHeadersAndCookies(harEntry, headers);
})); }));
// Record available headers including redirect location in case the tracing is stopped before
// reponse extra info is received (in Chromium).
this._recordResponseHeaders(harEntry, response.headers());
this._addBarrier(page || request.serviceWorker(), response.rawResponseHeaders().then(headers => { this._addBarrier(page || request.serviceWorker(), response.rawResponseHeaders().then(headers => {
if (!this._options.omitCookies) { this._recordResponseHeaders(harEntry, headers);
for (const header of headers.filter(header => header.name.toLowerCase() === 'set-cookie'))
harEntry.response.cookies.push(parseCookie(header.value));
}
harEntry.response.headers = headers;
const contentType = headers.find(header => header.name.toLowerCase() === 'content-type');
if (contentType)
harEntry.response.content.mimeType = contentType.value;
})); }));
} }
private _recordResponseHeaders(harEntry: har.Entry, headers: HeadersArray) {
if (!this._options.omitCookies) {
harEntry.response.cookies = headers
.filter(header => header.name.toLowerCase() === 'set-cookie')
.map(header => parseCookie(header.value));
}
harEntry.response.headers = headers;
const contentType = headers.find(header => header.name.toLowerCase() === 'content-type');
if (contentType)
harEntry.response.content.mimeType = contentType.value;
}
private _computeHarEntryTotalTime(harEntry: har.Entry) { private _computeHarEntryTotalTime(harEntry: har.Entry) {
harEntry.time = [ harEntry.time = [
harEntry.timings.dns, harEntry.timings.dns,