From 41e9b36f63f168352f7b3a335c3517d635056f99 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Sat, 26 Feb 2022 00:45:27 +0100 Subject: [PATCH] fix: install-deps did not throw on non 0 exit code (#12375) --- packages/playwright-core/src/utils/dependencies.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/playwright-core/src/utils/dependencies.ts b/packages/playwright-core/src/utils/dependencies.ts index cb6bc509e1..51e692f84c 100644 --- a/packages/playwright-core/src/utils/dependencies.ts +++ b/packages/playwright-core/src/utils/dependencies.ts @@ -78,8 +78,8 @@ export async function installDependenciesLinux(targets: Set, dr if (elevatedPermissions) console.log('Switching to root user to install dependencies...'); // eslint-disable-line no-console const child = childProcess.spawn(command, args, { stdio: 'inherit' }); - await new Promise((resolve, reject) => { - child.on('exit', resolve); + await new Promise((resolve, reject) => { + child.on('exit', (code: number) => code === 0 ? resolve() : reject(new Error(`Installation process exited with code: ${code}`))); child.on('error', reject); }); }