Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat: ignore InputElement.validity when irrelevant

Browse source
This commit is contained in:
Pengoose 2024-12-17 05:11:22 +09:00
parent 934271548d
commit 4298372d56
2 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/playwright-core/src/server/injected/roleUtils.ts
View file

@ -461,6 +461,16 @@ export function getElementAccessibleDescription(element: Element, includeHidden:
return accessibleDescription;
}
// https://html.spec.whatwg.org/multipage/input.html#the-input-element
export const kInputValidityAttributes = ['required', 'pattern', 'min', 'max', 'minlength', 'maxlength', 'step', 'type', 'value'];
export function hasValidationAttributes(element: Element): boolean {
if (!(element instanceof HTMLInputElement))
return false;
return kInputValidityAttributes.some(attr => element.hasAttribute(attr));
}
// https://www.w3.org/TR/wai-aria-1.2/#aria-invalid
export const kAriaInvalidRoles = ['application', 'checkbox', 'combobox', 'gridcell', 'listbox', 'radiogroup', 'slider', 'spinbutton', 'textbox', 'tree', 'columnheader', 'rowheader', 'searchbox', 'switch', 'treegrid'];
@ -468,7 +478,7 @@ export function getAriaInvalid(element: Element): 'false' | 'true' | 'grammar' |
const role = getAriaRole(element) || '';
if (!role || !kAriaInvalidRoles.includes(role))
return 'false';
if (element instanceof HTMLInputElement && element.validity)
if (element instanceof HTMLInputElement && hasValidationAttributes(element) && element.validity)
return element.validity.valid ? 'false' : 'true';
const ariaInvalid = element.getAttribute('aria-invalid');
if (!ariaInvalid || ariaInvalid.trim() === '' || ariaInvalid.toLocaleLowerCase() === 'false')

2
tests/page/expect-misc.spec.ts
View file

@ -528,7 +528,7 @@ test('toHaveAccessibleErrorMessage should handle multiple aria-errormessage refe
await expect(locator).not.toHaveAccessibleErrorMessage(/This should not be considered./i);
});
test.describe.only('toHaveAccessibleErrorMessage should handle aria-invalid attribute', () => {
test.describe('toHaveAccessibleErrorMessage should handle aria-invalid attribute', () => {
const errorMessageText = 'Error message';
async function setupPage(page, ariaInvalidValue: string | null) {