From 42c2cfc7cc1429d269c5d6a60faca1e107091f71 Mon Sep 17 00:00:00 2001
From: Pavel Feldman <pavel.feldman@gmail.com>
Date: Fri, 7 Feb 2020 11:48:55 -0800
Subject: [PATCH] fix(pipe): sort out pipes on platforms (#895)

---
 src/server/processLauncher.ts | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/server/processLauncher.ts b/src/server/processLauncher.ts
index 99ad26dc48..4f541cc898 100644
--- a/src/server/processLauncher.ts
+++ b/src/server/processLauncher.ts
@@ -49,13 +49,7 @@ let lastLaunchedId = 0;
 
 export async function launchProcess(options: LaunchProcessOptions): Promise<LaunchResult> {
   const id = ++lastLaunchedId;
-  let stdio: ('ignore' | 'pipe')[] = ['pipe', 'pipe', 'pipe'];
-  if (options.pipe) {
-    if (options.dumpio)
-      stdio = ['ignore', 'pipe', 'pipe', 'pipe', 'pipe'];
-    else
-      stdio = ['ignore', 'ignore', 'ignore', 'pipe', 'pipe'];
-  }
+  const stdio: ('ignore' | 'pipe')[] = options.pipe ? ['ignore', 'pipe', 'pipe', 'pipe', 'pipe'] : ['ignore', 'pipe', 'pipe'];
   const spawnedProcess = childProcess.spawn(
       options.executablePath,
       options.args,
@@ -80,8 +74,11 @@ export async function launchProcess(options: LaunchProcessOptions): Promise<Laun
   }
 
   if (options.dumpio) {
-    spawnedProcess.stderr.pipe(process.stderr);
     spawnedProcess.stdout.pipe(process.stdout);
+    spawnedProcess.stderr.pipe(process.stderr);
+  } else {
+    spawnedProcess.stderr.on('data', () => {});
+    spawnedProcess.stdout.on('data', () => {});
   }
 
   let processClosed = false;