Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat: show browser.close() stack in "Browser has been closed" error (#17376)

Browse source 
Often times we see "Browser has been closed" error, but it's not
entirely clear why. Showing the close stack might help.

```js
page.goto: Connection closed
    ==== Closed by ====
    at /Users/dgozman/code/playwright/tests/library/browsertype-connect.spec.ts:477:32
```
This commit is contained in:
Dmitry Gozman 2022-09-15 17:04:41 -07:00 committed by GitHub
parent 24d3a23a66
commit 43304e980d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/playwright-core/src/client/connection.ts
View file

@ -36,7 +36,7 @@ import { WritableStream } from './writableStream';
import { debugLogger } from '../common/debugLogger'; import { debugLogger } from '../common/debugLogger';
import { SelectorsOwner } from './selectors'; import { SelectorsOwner } from './selectors';
import { Android, AndroidSocket, AndroidDevice } from './android'; import { Android, AndroidSocket, AndroidDevice } from './android';
import type { ParsedStackTrace } from '../utils/stackTrace'; import { captureStackTrace, type ParsedStackTrace } from '../utils/stackTrace';
import { Artifact } from './artifact'; import { Artifact } from './artifact';
import { EventEmitter } from 'events'; import { EventEmitter } from 'events';
import { JsonPipe } from './jsonPipe'; import { JsonPipe } from './jsonPipe';
@ -166,6 +166,9 @@ export class Connection extends EventEmitter {
} }
close(errorMessage: string = 'Connection closed') { close(errorMessage: string = 'Connection closed') {
const stack = captureStackTrace().frameTexts.join('\n');
if (stack)
errorMessage += '\n ==== Closed by ====\n' + stack + '\n';
this._closedErrorMessage = errorMessage; this._closedErrorMessage = errorMessage;
for (const callback of this._callbacks.values()) for (const callback of this._callbacks.values())
callback.reject(new Error(errorMessage)); callback.reject(new Error(errorMessage));

5
tests/library/browsertype-connect.spec.ts
View file

@ -478,7 +478,10 @@ test('should properly disconnect when connection closes from the client side', a
await disconnectedPromise; await disconnectedPromise;
expect(browser.isConnected()).toBe(false); expect(browser.isConnected()).toBe(false);
expect((await navigationPromise).message).toContain('Connection closed'); const navMessage = (await navigationPromise).message;
expect(navMessage).toContain('Connection closed');
expect(navMessage).toContain('Closed by');
expect(navMessage).toContain(__filename);
expect((await waitForNavigationPromise).message).toContain('Navigation failed because page was closed'); expect((await waitForNavigationPromise).message).toContain('Navigation failed because page was closed');
expect((await page.goto(server.EMPTY_PAGE).catch(e => e)).message).toContain('has been closed'); expect((await page.goto(server.EMPTY_PAGE).catch(e => e)).message).toContain('has been closed');
expect((await page.waitForNavigation().catch(e => e)).message).toContain('Navigation failed because page was closed'); expect((await page.waitForNavigation().catch(e => e)).message).toContain('Navigation failed because page was closed');