Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(xmldocs): over-greedy regex for md links and clean-up (#5798)

Browse source 
* fix(xmldocs): over-greedy regex for Markdown links
* fix(dotnet): missing using and extra spaces
This commit is contained in:
Anže Vodovnik 2021-03-11 18:07:45 +01:00 committed by GitHub
parent 6a8c8d9c87
commit 43de259522
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
utils/doclint/generateDotnetApi.js
View file

@ -364,7 +364,7 @@ function generateEnumNameIfApplicable(member, name, type, parent) {
function renderMethod(member, parent, output, name) { function renderMethod(member, parent, output, name) {
const typeResolve = (type) => translateType(type, parent, (t) => { const typeResolve = (type) => translateType(type, parent, (t) => {
let newName = `${parent.name}${translateMemberName(member.kind, member.name, null)}Result`; let newName = `${parent.name}${translateMemberName(member.kind, member.name, null)}Result`;
documentedResults.set(newName, `Result of calling <see cref="${translateMemberName("interface", parent.name)}.${translateMemberName(member.kind, member.name, member)}" />.`); documentedResults.set(newName, `Result of calling <see cref="${translateMemberName("interface", parent.name)}.${translateMemberName(member.kind, member.name, member)}"/>.`);
return newName; return newName;
}); });

1
utils/doclint/templates/interface.cs
View file

@ -39,6 +39,7 @@ using System.Globalization;
using System.IO; using System.IO;
using System.Runtime.Serialization; using System.Runtime.Serialization;
using System.Text.Json; using System.Text.Json;
using System.Text.Json.Serialization;
using System.Text.RegularExpressions; using System.Text.RegularExpressions;
using System.Threading; using System.Threading;
using System.Threading.Tasks; using System.Threading.Tasks;

6
utils/doclint/xmlDocumentation.js
View file

@ -118,11 +118,11 @@ function _wrapAndEscape(node, maxColumns = 0) {
let text = node.text; let text = node.text;
text = text.replace(/`([^`]*)`/g, (match, code) => `<c>${code.replace('<', '&lt;').replace('>', '&gt;')}</c>`); text = text.replace(/\[(.*?)\]\((.*?)\)/g, (match, linkName, linkUrl) => {
text = text.replace(/\[(.*?)\]\((.*?\))/g, (match, linkName, linkUrl) => {
return `<a href="${linkUrl}">${linkName}</a>`; return `<a href="${linkUrl}">${linkName}</a>`;
}); });
text = text.replace(/\[(.*?)\]/g, (match, link) => `<see cref="${link}" />`); text = text.replace(/(?<!`)\[(.*?)\]/g, (match, link) => `<see cref="${link}"/>`);
text = text.replace(/`([^`]*)`/g, (match, code) => `<c>${code.replace('<', '&lt;').replace('>', '&gt;')}</c>`);
const words = text.split(' '); const words = text.split(' ');
let line = ''; let line = '';
for (let i = 0; i < words.length; i++) { for (let i = 0; i < words.length; i++) {