From 44445e30e56bbaf7842a4ab4a6670c0164122902 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Thu, 8 Aug 2024 10:57:44 -0700
Subject: [PATCH] fix(ui mode): make sure key for attachment view is unique
 (#32084)

Fixes #32052.
---
 packages/trace-viewer/src/ui/attachmentsTab.tsx | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/trace-viewer/src/ui/attachmentsTab.tsx b/packages/trace-viewer/src/ui/attachmentsTab.tsx
index 375f28cb65..8c72c7fee3 100644
--- a/packages/trace-viewer/src/ui/attachmentsTab.tsx
+++ b/packages/trace-viewer/src/ui/attachmentsTab.tsx
@@ -131,7 +131,7 @@ export const AttachmentsTab: React.FunctionComponent<{
     })}
     {attachments.size ? <div className='attachments-section'>Attachments</div> : undefined}
     {[...attachments.values()].map((a, i) => {
-      return <div className='attachment-item' key={`attachment-${i}`}>
+      return <div className='attachment-item' key={attachmentKey(a, i)}>
         <ExpandableAttachment attachment={a} />
       </div>;
     })}
@@ -154,3 +154,7 @@ function downloadURL(attachment: Attachment) {
     params.dct = attachment.contentType;
   return attachmentURL(attachment, params);
 }
+
+function attachmentKey(attachment: Attachment, index: number) {
+  return index + '-' + (attachment.sha1 ? `sha1-` + attachment.sha1 : `path-` + attachment.path);
+}