From 4478c653fd7f36eaa0707e9c36a203050fafdbd5 Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Thu, 5 Dec 2019 11:21:55 -0800 Subject: [PATCH] fix(install): generate new protocol.d.ts when browsers are downloaded (#149) --- docs/api.md | 2 -- src/download.ts | 4 +++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/api.md b/docs/api.md index 4d3e5c40d6..afe0318acd 100644 --- a/docs/api.md +++ b/docs/api.md @@ -446,8 +446,6 @@ const iPhone = playwright.devices['iPhone 6']; Downloads the default browser that Playwright controls. The browser is usually around 100mb. -> **NOTE** Depending on your terminal, the progress bar might not appear. - #### playwright.errors - returns: <[Object]> - `TimeoutError` <[function]> A class of [TimeoutError]. diff --git a/src/download.ts b/src/download.ts index cfb8e10bb7..a1a44d0d80 100644 --- a/src/download.ts +++ b/src/download.ts @@ -8,7 +8,9 @@ export async function download( revision: string, browserName: string, {onProgress}: {onProgress?: (downloadedBytes: number, totalBytes: number) => void} = {}) : Promise { - return await browserFetcher.download(revision, onProgress); + const revisionInfo = browserFetcher.revisionInfo(revision); + await browserFetcher.download(revision, onProgress); + return revisionInfo; } export type RevisionInfo = {