Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: disable source-map reference in JS for production builds (#7622)

Browse source
This commit is contained in:
Max Schmitt 2021-07-22 20:29:36 +02:00 committed by GitHub
parent 8f1074c76e
commit 449c8a77dd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/utils/stackTrace.ts
View file

@ -39,9 +39,14 @@ const PW_LIB_DIRS = [
path.join('@playwright', 'test'), path.join('@playwright', 'test'),
].map(packageName => path.sep + packageName); ].map(packageName => path.sep + packageName);
const runnerLib = path.join('@playwright', 'test', 'lib', 'test'); const runnerNpmPkgLib = path.join('@playwright', 'test', 'lib', 'test');
const runnerLib = path.join('lib', 'test');
const runnerSrc = path.join('src', 'test'); const runnerSrc = path.join('src', 'test');
function includesFileInPlaywrightSubDir(subDir: string, fileName: string) {
return PW_LIB_DIRS.map(p => path.join(p, subDir)).some(libDir => fileName.includes(libDir));
}
export type ParsedStackTrace = { export type ParsedStackTrace = {
frames: StackFrame[]; frames: StackFrame[];
frameTexts: string[]; frameTexts: string[];
@ -59,7 +64,7 @@ export function captureStackTrace(): ParsedStackTrace {
const lines = stack.split('\n').reverse(); const lines = stack.split('\n').reverse();
let apiName = ''; let apiName = '';
const isTesting = process.env.PWTEST_CLI_ALLOW_TEST_COMMAND || isUnderTest(); const isTesting = !!process.env.PWTEST_CLI_ALLOW_TEST_COMMAND || isUnderTest();
for (const line of lines) { for (const line of lines) {
const frame = stackUtils.parseLine(line); const frame = stackUtils.parseLine(line);
@ -70,7 +75,7 @@ export function captureStackTrace(): ParsedStackTrace {
const fileName = path.resolve(process.cwd(), frame.file); const fileName = path.resolve(process.cwd(), frame.file);
if (isTesting && fileName.includes(path.join('playwright', 'tests', 'config', 'coverage.js'))) if (isTesting && fileName.includes(path.join('playwright', 'tests', 'config', 'coverage.js')))
continue; continue;
if (!fileName.includes(runnerLib) && !(isTesting && fileName.includes(runnerSrc)) && PW_LIB_DIRS.map(p => path.join(p, isTesting ? 'src' : 'lib')).some(libDir => fileName.includes(libDir))) { if (isFilePartOfPlaywright(isTesting, fileName)) {
apiName = frame.function ? frame.function[0].toLowerCase() + frame.function.slice(1) : ''; apiName = frame.function ? frame.function[0].toLowerCase() + frame.function.slice(1) : '';
break; break;
} }
@ -87,6 +92,13 @@ export function captureStackTrace(): ParsedStackTrace {
return { frames, frameTexts, apiName }; return { frames, frameTexts, apiName };
} }
function isFilePartOfPlaywright(isTesting: boolean, fileName: string): boolean {
const isPlaywrightTest = fileName.includes(runnerNpmPkgLib);
const isLocalPlaywright = isTesting && (fileName.includes(runnerSrc) || fileName.includes(runnerLib));
const isInPlaywright = (includesFileInPlaywrightSubDir('src', fileName) || includesFileInPlaywrightSubDir('lib', fileName));
return !isPlaywrightTest && !isLocalPlaywright && isInPlaywright;
}
export function splitErrorMessage(message: string): { name: string, message: string } { export function splitErrorMessage(message: string): { name: string, message: string } {
const separationIdx = message.indexOf(':'); const separationIdx = message.indexOf(':');
return { return {

2
utils/build/build.js
View file

@ -109,7 +109,7 @@ for (const file of webPackFiles) {
// Run Babel. // Run Babel.
steps.push({ steps.push({
command: 'npx', command: 'npx',
args: ['babel', ...(watchMode ? ['-w'] : []), '-s', '--extensions', '.ts', '--out-dir', filePath('./lib/'), filePath('./src/')], args: ['babel', ...(watchMode ? ['-w', '--source-maps'] : []), '--extensions', '.ts', '--out-dir', filePath('./lib/'), filePath('./src/')],
shell: true, shell: true,
}); });