From 454b6f938d98c7982b8278e63dd4b1a6dcfdf395 Mon Sep 17 00:00:00 2001 From: Julian Descottes Date: Mon, 13 Jan 2025 22:56:00 +0100 Subject: [PATCH] test(bidi): Update browserName used for har file tests when using bidi (#34313) --- tests/library/har.spec.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/library/har.spec.ts b/tests/library/har.spec.ts index 92358608e9..88419e742c 100644 --- a/tests/library/har.spec.ts +++ b/tests/library/har.spec.ts @@ -60,7 +60,10 @@ it('should have browser', async ({ browserName, browser, contextFactory, server const { page, getLog } = await pageWithHar(contextFactory, testInfo); await page.goto(server.EMPTY_PAGE); const log = await getLog(); - expect(log.browser!.name.toLowerCase()).toBe(browserName); + + // _bidiFirefox and _bidiChromium are initialized with 'bidi' as browser name. + const harBrowserName = browserName.startsWith('_bidi') ? 'bidi' : browserName; + expect(log.browser!.name.toLowerCase()).toBe(harBrowserName); expect(log.browser!.version).toBe(browser.version()); }); @@ -957,6 +960,9 @@ it('should not hang on slow chunked response', async ({ browserName, browser, co await page.goto(server.EMPTY_PAGE); await page.evaluate(() => (window as any).receivedFirstData); const log = await getLog(); - expect(log.browser!.name.toLowerCase()).toBe(browserName); + + // _bidiFirefox and _bidiChromium are initialized with 'bidi' as browser name. + const harBrowserName = browserName.startsWith('_bidi') ? 'bidi' : browserName; + expect(log.browser!.name.toLowerCase()).toBe(harBrowserName); expect(log.browser!.version).toBe(browser.version()); });