From 4696dd8682be4f644602a89594945e8b0f8f162c Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Fri, 22 Nov 2024 17:35:35 +0000 Subject: [PATCH] fix(chromium): race between oopif attach and context clear (#33729) --- packages/playwright-core/src/server/chromium/crPage.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/playwright-core/src/server/chromium/crPage.ts b/packages/playwright-core/src/server/chromium/crPage.ts index 57ebc5fa69..f3f21121e5 100644 --- a/packages/playwright-core/src/server/chromium/crPage.ts +++ b/packages/playwright-core/src/server/chromium/crPage.ts @@ -731,6 +731,10 @@ class FrameSession { if (!frame) return; // Subtree may be already gone due to renderer/browser race. this._page._frameManager.removeChildFramesRecursively(frame); + for (const [contextId, context] of this._contextIdToContext) { + if (context.frame === frame) + this._onExecutionContextDestroyed(contextId); + } const frameSession = new FrameSession(this._crPage, session, targetId, this); this._crPage._sessions.set(targetId, frameSession); frameSession._initialize(false).catch(e => e);