Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

use manualpromise

Browse source
This commit is contained in:
Simon Knott 2024-09-03 08:46:40 +02:00
parent 7d191d3a39
commit 46d19c9682
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/playwright/src/runner/watchMode.ts
View file

@ -46,7 +46,6 @@ class InMemoryTransport extends EventEmitter implements TestServerTransport {
onerror(listener: () => void): void { onerror(listener: () => void): void {
// no-op to fulfil the interface, the user of InMemoryTransport doesn't emit any errors. // no-op to fulfil the interface, the user of InMemoryTransport doesn't emit any errors.
this.on('error', listener);
} }
onmessage(listener: (message: string) => void): void { onmessage(listener: (message: string) => void): void {
@ -92,7 +91,7 @@ export async function runWatchModeLoop(configLocation: ConfigLocation, initialOp
const teleSuiteUpdater = new TeleSuiteUpdater({ pathSeparator: path.sep, onUpdate() { } }); const teleSuiteUpdater = new TeleSuiteUpdater({ pathSeparator: path.sep, onUpdate() { } });
const dirtyTestIds = new Set<string>(); const dirtyTestIds = new Set<string>();
const onDirtyTests: { resolve?(): void } = {}; let onDirtyTests = new ManualPromise();
let queue = Promise.resolve(); let queue = Promise.resolve();
@ -135,7 +134,7 @@ export async function runWatchModeLoop(configLocation: ConfigLocation, initialOp
printPrompt(); printPrompt();
const readCommandPromise = readCommand(); const readCommandPromise = readCommand();
await Promise.race([ await Promise.race([
new Promise<void>(resolve => { onDirtyTests.resolve = resolve; }), onDirtyTests,
readCommandPromise, readCommandPromise,
]); ]);
if (!readCommandPromise.isDone()) if (!readCommandPromise.isDone())
@ -144,6 +143,7 @@ export async function runWatchModeLoop(configLocation: ConfigLocation, initialOp
const command = await readCommandPromise; const command = await readCommandPromise;
if (command === 'changed') { if (command === 'changed') {
onDirtyTests = new ManualPromise();
const testIds = [...dirtyTestIds]; const testIds = [...dirtyTestIds];
dirtyTestIds.clear(); dirtyTestIds.clear();
await runTests(options, testServerConnection, { testIds, title: 'files changed' }); await runTests(options, testServerConnection, { testIds, title: 'files changed' });