Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

review feedback

Browse source
This commit is contained in:
Max Schmitt 2024-09-11 11:53:21 +02:00
parent 059a678470
commit 483b304e22
2 changed files with 4 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/playwright/src/runner/failureTracker.ts
View file

@ -31,12 +31,9 @@ export class FailureTracker {
} }
onTestEnd(test: TestCase, result: TestResult) { onTestEnd(test: TestCase, result: TestResult) {
if (result.status === 'skipped') // Test is considered failing after the last retry.
return; if (test.outcome() === 'unexpected' && test.results.length > test.retries)
if (result.status !== test.expectedStatus)
++this._failureCount; ++this._failureCount;
else
this._failureCount -= result.retry;
} }
onWorkerError() { onWorkerError() {

13
tests/playwright-test/max-failures.spec.ts
View file

@ -191,27 +191,18 @@ test('max-failures should not consider retries as failures', async ({ runInlineT
}; };
`, `,
'example.spec.ts': ` 'example.spec.ts': `
import fs from 'fs';
import { test, expect } from '@playwright/test'; import { test, expect } from '@playwright/test';
test('I fail 9 times 1', () => { test('I fail 9 times 1', () => {
let count = parseInt(fs.readFileSync('count1', 'utf8'), 10); if (test.info().retry < 9)
count++;
fs.writeFileSync('count1', String(count));
if (count < 10)
throw new Error('failing intentionally'); throw new Error('failing intentionally');
}); });
test('I fail 9 times 2', () => { test('I fail 9 times 2', () => {
let count = parseInt(fs.readFileSync('count2', 'utf8'), 10); if (test.info().retry < 9)
count++;
fs.writeFileSync('count2', String(count));
if (count < 10)
throw new Error('failing intentionally'); throw new Error('failing intentionally');
}); });
`, `,
'count1': '0',
'count2': '0',
}, { workers: 1 }); }, { workers: 1 });
expect(result.exitCode).toBe(0); expect(result.exitCode).toBe(0);
expect(result.failed).toBe(0); expect(result.failed).toBe(0);