diff --git a/.eslintrc.js b/.eslintrc.js index bb351a8c56..a116a37036 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -6,9 +6,14 @@ module.exports = { sourceType: "module", }, extends: [ + "plugin:react/recommended", "plugin:react-hooks/recommended" ], + settings: { + react: { version: "18" } + }, + /** * ESLint rules * @@ -124,5 +129,8 @@ module.exports = { "mustMatch": "Copyright", "templateFile": require("path").join(__dirname, "utils", "copyright.js"), }], + + // react + "react/react-in-jsx-scope": 0 } }; diff --git a/packages/html-reporter/src/icons.tsx b/packages/html-reporter/src/icons.tsx index 6111fac7c1..9609a2e23f 100644 --- a/packages/html-reporter/src/icons.tsx +++ b/packages/html-reporter/src/icons.tsx @@ -70,19 +70,19 @@ export const blank = () => { }; export const externalLink = () => { - return ; + return ; }; export const calendar = () => { - return ; + return ; }; export const person = () => { - return ; + return ; }; export const commit = () => { - return ; + return ; }; export const image = () => { diff --git a/packages/html-reporter/src/links.tsx b/packages/html-reporter/src/links.tsx index 55d7d24a6c..419a8725ac 100644 --- a/packages/html-reporter/src/links.tsx +++ b/packages/html-reporter/src/links.tsx @@ -81,7 +81,7 @@ export const AttachmentLink: React.FunctionComponent<{ {attachment.path && {linkName || attachment.name}} {!attachment.path && {linkifyText(attachment.name)}} } loadChildren={attachment.body ? () => { - return [
{linkifyText(attachment.body!)}
]; + return [
{linkifyText(attachment.body!)}
]; } : undefined} depth={0} style={{ lineHeight: '32px' }}>; }; diff --git a/packages/html-reporter/src/testCaseView.tsx b/packages/html-reporter/src/testCaseView.tsx index 4da49261d0..5bed3c8309 100644 --- a/packages/html-reporter/src/testCaseView.tsx +++ b/packages/html-reporter/src/testCaseView.tsx @@ -58,7 +58,7 @@ export const TestCaseView: React.FC<{ {labels && } } {!!visibleAnnotations.length && - {visibleAnnotations.map(annotation => )} + {visibleAnnotations.map((annotation, index) => )} } {test && ({ diff --git a/packages/recorder/src/recorder.tsx b/packages/recorder/src/recorder.tsx index b3966fd01a..486aeae701 100644 --- a/packages/recorder/src/recorder.tsx +++ b/packages/recorder/src/recorder.tsx @@ -171,7 +171,7 @@ export const Recorder: React.FC = ({ sidebarSize={200} main={} sidebar={ copy(locator)} />] : []} + rightToolbar={selectedTab === 'locator' ? [ copy(locator)} />] : []} tabs={[ { id: 'locator', diff --git a/packages/trace-viewer/src/ui/attachmentsTab.tsx b/packages/trace-viewer/src/ui/attachmentsTab.tsx index 8c72c7fee3..8b6cefe14d 100644 --- a/packages/trace-viewer/src/ui/attachmentsTab.tsx +++ b/packages/trace-viewer/src/ui/attachmentsTab.tsx @@ -126,7 +126,7 @@ export const AttachmentsTab: React.FunctionComponent<{ const url = attachmentURL(a); return ; })} {attachments.size ?
Attachments
: undefined} diff --git a/packages/trace-viewer/src/ui/consoleTab.tsx b/packages/trace-viewer/src/ui/consoleTab.tsx index a7b8318386..b2947f5011 100644 --- a/packages/trace-viewer/src/ui/consoleTab.tsx +++ b/packages/trace-viewer/src/ui/consoleTab.tsx @@ -213,6 +213,7 @@ function format(args: { preview: string, value: any }[]): JSX.Element[] { } function formatAnsi(text: string): JSX.Element[] { + // eslint-disable-next-line react/jsx-key return []; } diff --git a/packages/trace-viewer/src/ui/networkFilters.tsx b/packages/trace-viewer/src/ui/networkFilters.tsx index de6c827e2b..a88332e7c6 100644 --- a/packages/trace-viewer/src/ui/networkFilters.tsx +++ b/packages/trace-viewer/src/ui/networkFilters.tsx @@ -26,10 +26,10 @@ export type FilterState = { export const defaultFilterState: FilterState = { searchValue: '', resourceType: 'All' }; -export const NetworkFilters: React.FunctionComponent<{ +export const NetworkFilters = ({ filterState, onFilterStateChange }: { filterState: FilterState, onFilterStateChange: (filterState: FilterState) => void, -}> = ({ filterState, onFilterStateChange }) => { +}) => { return (
]} + leftToolbar={[]} tabs={[ { id: 'request', diff --git a/packages/trace-viewer/src/ui/snapshotTab.tsx b/packages/trace-viewer/src/ui/snapshotTab.tsx index 798025cbbd..4faa668677 100644 --- a/packages/trace-viewer/src/ui/snapshotTab.tsx +++ b/packages/trace-viewer/src/ui/snapshotTab.tsx @@ -184,6 +184,7 @@ export const SnapshotTab: React.FunctionComponent<{ setIsInspecting(!isInspecting)} /> {['action', 'before', 'after'].map(tab => { return void }> = ({ tag, style, onClick }) => { +export const TagViev = ({ tag, style, onClick }: { tag: string, style?: React.CSSProperties, onClick?: (e: React.MouseEvent) => void }) => { return
{[...statusFilters.entries()].map(([status, value]) => { - return
+ return
{[...projectFilters.entries()].map(([projectName, value]) => { - return
+ return