From 48ab172bdafc315333363a3bf9c9189cf76643f3 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Wed, 8 Jun 2022 14:13:39 -0800 Subject: [PATCH] tests(fixit): garden win/webkit/input tests (#14721) Bumping images to 300+ to work around the non-sensible minimal size. --- tests/library/browsercontext-viewport.spec.ts | 4 ++-- tests/library/inspector/cli-codegen-2.spec.ts | 3 +-- tests/page/page-focus.spec.ts | 3 +-- tests/page/page-screenshot.spec.ts | 4 ++-- .../white-chromium.jpg | Bin 911 -> 1379 bytes .../white-firefox.jpg | Bin 923 -> 3154 bytes .../white-webkit.jpg | Bin 908 -> 3138 bytes 7 files changed, 6 insertions(+), 8 deletions(-) diff --git a/tests/library/browsercontext-viewport.spec.ts b/tests/library/browsercontext-viewport.spec.ts index e854e3c011..1451cb7165 100644 --- a/tests/library/browsercontext-viewport.spec.ts +++ b/tests/library/browsercontext-viewport.spec.ts @@ -25,8 +25,8 @@ it('should get the proper default viewport size', async ({ page, server }) => { it('should set the proper viewport size', async ({ page, server }) => { await verifyViewport(page, 1280, 720); - await page.setViewportSize({ width: 123, height: 456 }); - await verifyViewport(page, 123, 456); + await page.setViewportSize({ width: 345, height: 456 }); + await verifyViewport(page, 345, 456); }); it('should return correct outerWidth and outerHeight', async ({ page }) => { diff --git a/tests/library/inspector/cli-codegen-2.spec.ts b/tests/library/inspector/cli-codegen-2.spec.ts index 1b55c96c82..30e3f1bf50 100644 --- a/tests/library/inspector/cli-codegen-2.spec.ts +++ b/tests/library/inspector/cli-codegen-2.spec.ts @@ -473,8 +473,7 @@ test.describe('cli codegen', () => { }); test('should update active model on action', async ({ page, openRecorder, browserName, headless }) => { - test.fixme(browserName === 'webkit' && headless); - test.fixme(browserName === 'firefox' && headless); + test.fixme(browserName !== 'chromium'); const recorder = await openRecorder(); await recorder.setContentAndWait(``); diff --git a/tests/page/page-focus.spec.ts b/tests/page/page-focus.spec.ts index 23c49bd8de..b8ee9b6294 100644 --- a/tests/page/page-focus.spec.ts +++ b/tests/page/page-focus.spec.ts @@ -109,8 +109,7 @@ it('should traverse only form elements', async function({ page, browserName, pla }); it('clicking checkbox should activate it', async ({ page, browserName, headless, platform }) => { - it.fixme(browserName === 'webkit' && headless); - it.fixme(browserName === 'firefox' && headless && platform === 'darwin'); + it.fixme(browserName !== 'chromium'); await page.setContent(``); await page.click('input'); diff --git a/tests/page/page-screenshot.spec.ts b/tests/page/page-screenshot.spec.ts index c5237f6fcb..b216c79805 100644 --- a/tests/page/page-screenshot.spec.ts +++ b/tests/page/page-screenshot.spec.ts @@ -202,7 +202,7 @@ it.describe('page screenshot', () => { it('should render white background on jpeg file', async ({ page, server, isElectron }) => { it.fixme(isElectron, 'omitBackground with jpeg does not work'); - await page.setViewportSize({ width: 100, height: 100 }); + await page.setViewportSize({ width: 300, height: 300 }); await page.goto(server.EMPTY_PAGE); const screenshot = await page.screenshot({ omitBackground: true, type: 'jpeg' }); expect(screenshot).toMatchSnapshot('white.jpg'); @@ -314,7 +314,7 @@ it.describe('page screenshot', () => { it('path option should detect jpeg', async ({ page, server, isElectron }, testInfo) => { it.fixme(isElectron, 'omitBackground with jpeg does not work'); - await page.setViewportSize({ width: 100, height: 100 }); + await page.setViewportSize({ width: 300, height: 300 }); await page.goto(server.EMPTY_PAGE); const outputPath = testInfo.outputPath('screenshot.jpg'); const screenshot = await page.screenshot({ omitBackground: true, path: outputPath }); diff --git a/tests/page/page-screenshot.spec.ts-snapshots/white-chromium.jpg b/tests/page/page-screenshot.spec.ts-snapshots/white-chromium.jpg index 0bc91643aa8e07a936964f85338bcd347189d70c..ed816ce76636aa521c8534953247ea68d7df5916 100644 GIT binary patch delta 61 rcmeBYf6O&OkBP-#qrqGz7DgRLoyixOc25pqw8DocCa^HG|GxJ`1A`qt3>~Pnk9sFi9{HB={Mb?f>5d021gCHvj+t delta 20 ccmX>k(ZfDrJ_|z%L(0a*PnlT$GyJ~^08aY|e*gdg