From 4b5b326478343b2e6c4fefcb158c6a8f35327d6e Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Wed, 29 Jan 2025 12:41:09 -0800 Subject: [PATCH] chore: do not show steps in line reporter without tty (#34529) --- packages/playwright/src/reporters/line.ts | 4 ++-- tests/playwright-test/reporter-line.spec.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/playwright/src/reporters/line.ts b/packages/playwright/src/reporters/line.ts index 96e393c1cf..4ff5221224 100644 --- a/packages/playwright/src/reporters/line.ts +++ b/packages/playwright/src/reporters/line.ts @@ -68,12 +68,12 @@ class LineReporter extends TerminalReporter { } onStepBegin(test: TestCase, result: TestResult, step: TestStep) { - if (step.category === 'test.step') + if (this.screen.isTTY && step.category === 'test.step') this._updateLine(test, result, step); } onStepEnd(test: TestCase, result: TestResult, step: TestStep) { - if (step.category === 'test.step') + if (this.screen.isTTY && step.category === 'test.step') this._updateLine(test, result, step.parent); } diff --git a/tests/playwright-test/reporter-line.spec.ts b/tests/playwright-test/reporter-line.spec.ts index 7322af433f..9c69fd9cdc 100644 --- a/tests/playwright-test/reporter-line.spec.ts +++ b/tests/playwright-test/reporter-line.spec.ts @@ -125,7 +125,7 @@ for (const useIntermediateMergeReport of [false, true] as const) { }); }); `, - }, { reporter: 'line' }); + }, { reporter: 'line' }, { PLAYWRIGHT_FORCE_TTY: '1' }); const text = result.output; expect(text).toContain('[1/1] a.test.ts:3:15 › passes › outer › inner'); expect(result.exitCode).toBe(0);