From 4d34a1a37102ab7307c659498205b5156c0663b9 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Wed, 2 Nov 2022 14:57:19 -0700 Subject: [PATCH] chore: do not generate role= selector, use internal (#18519) --- .../playwright-core/src/server/injected/selectorGenerator.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/playwright-core/src/server/injected/selectorGenerator.ts b/packages/playwright-core/src/server/injected/selectorGenerator.ts index 22914538f7..5ac7b852a7 100644 --- a/packages/playwright-core/src/server/injected/selectorGenerator.ts +++ b/packages/playwright-core/src/server/injected/selectorGenerator.ts @@ -215,9 +215,9 @@ function buildTextCandidates(injectedScript: InjectedScript, element: Element, i if (ariaRole) { const ariaName = getElementAccessibleName(element, false, accessibleNameCache); if (ariaName) - candidate.push({ engine: 'role', selector: `${ariaRole}[name=${escapeForAttributeSelector(ariaName, true)}]`, score: 10 }); + candidate.push({ engine: 'internal:role', selector: `${ariaRole}[name=${escapeForAttributeSelector(ariaName, true)}]`, score: 10 }); else - candidate.push({ engine: 'role', selector: ariaRole, score: 10 }); + candidate.push({ engine: 'internal:role', selector: ariaRole, score: 10 }); } else { candidate.push({ engine: 'css', selector: element.nodeName.toLowerCase(), score: 10 }); }