Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

address feedback

Browse source
This commit is contained in:
Simon Knott 2024-08-22 13:11:00 +02:00
parent 355fa044c9
commit 4d61b4140b
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright/src/program.ts
View file

@ -198,7 +198,7 @@ async function runTests(args: string[], opts: { [key: string]: any }) {
config.cliGrepInvert = opts.grepInvert as string | undefined; config.cliGrepInvert = opts.grepInvert as string | undefined;
config.cliListOnly = !!opts.list; config.cliListOnly = !!opts.list;
config.cliProjectFilter = opts.project || undefined; config.cliProjectFilter = opts.project || undefined;
config.cliPassWithNoTests = !!(opts.passWithNoTests ?? opts.onlyChanged); config.cliPassWithNoTests =opts.passWithNoTests;
config.cliFailOnFlakyTests = !!opts.failOnFlakyTests; config.cliFailOnFlakyTests = !!opts.failOnFlakyTests;
const runner = new Runner(config); const runner = new Runner(config);

2
packages/playwright/src/runner/tasks.ts
View file

@ -239,7 +239,7 @@ function createLoadTask(mode: 'out-of-process' | 'in-process', options: { filter
testRun.rootSuite = await createRootSuite(testRun, options.failOnLoadErrors ? errors : softErrors, !!options.filterOnly, cliOnlyChangedMatcher); testRun.rootSuite = await createRootSuite(testRun, options.failOnLoadErrors ? errors : softErrors, !!options.filterOnly, cliOnlyChangedMatcher);
testRun.failureTracker.onRootSuite(testRun.rootSuite); testRun.failureTracker.onRootSuite(testRun.rootSuite);
// Fail when no tests. // Fail when no tests.
if (options.failOnLoadErrors && !testRun.rootSuite.allTests().length && !testRun.config.cliPassWithNoTests && !testRun.config.config.shard) { if (options.failOnLoadErrors && !testRun.rootSuite.allTests().length && !testRun.config.cliPassWithNoTests && !testRun.config.config.shard && !testRun.config.cliOnlyChanged) {
if (testRun.config.cliArgs.length) { if (testRun.config.cliArgs.length) {
throw new Error([ throw new Error([
`No tests found.`, `No tests found.`,