Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(rpc): nice error stacks when running tests (#3507)

Browse source
This commit is contained in:
Joel Einbinder 2020-08-28 16:47:06 -07:00 committed by GitHub
parent c2cd963407
commit 4e5007ae1a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/client/channelOwner.ts
View file

@ -19,6 +19,7 @@ import * as channels from '../protocol/channels';
import type { Connection } from './connection'; import type { Connection } from './connection';
import type { Logger } from './types'; import type { Logger } from './types';
import { debugLogger } from '../utils/debugLogger'; import { debugLogger } from '../utils/debugLogger';
import { isDevMode } from '../utils/utils';
export abstract class ChannelOwner<T extends channels.Channel = channels.Channel, Initializer = {}> extends EventEmitter { export abstract class ChannelOwner<T extends channels.Channel = channels.Channel, Initializer = {}> extends EventEmitter {
private _connection: Connection; private _connection: Connection;
@ -99,10 +100,9 @@ export abstract class ChannelOwner<T extends channels.Channel = channels.Channel
return result; return result;
} catch (e) { } catch (e) {
logApiCall(logger, `<= ${apiName} failed`); logApiCall(logger, `<= ${apiName} failed`);
// TODO: we could probably save "e.stack" in some log-heavy mode const innerStack = (isDevMode() && e.stack) ? e.stack.substring(e.stack.indexOf(e.message) + e.message.length) : '';
// because it gives some insights into the server part.
e.message = `${apiName}: ` + e.message; e.message = `${apiName}: ` + e.message;
e.stack = e.message + stack; e.stack = e.message + innerStack + stack;
throw e; throw e;
} }
} }