From 4e5aa3c9c331c1a20783111b7660199c90f62a41 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Fri, 31 Jul 2020 09:31:55 -0700
Subject: [PATCH] feat(rpc): support chromiumSandbox option (#3251)

---
 src/rpc/channels.ts  | 6 ++++++
 src/rpc/protocol.yml | 3 +++
 src/rpc/validator.ts | 3 +++
 3 files changed, 12 insertions(+)

diff --git a/src/rpc/channels.ts b/src/rpc/channels.ts
index 431099e2e5..42182b6db5 100644
--- a/src/rpc/channels.ts
+++ b/src/rpc/channels.ts
@@ -181,6 +181,7 @@ export type BrowserTypeLaunchParams = {
   },
   downloadsPath?: string,
   firefoxUserPrefs?: SerializedValue,
+  chromiumSandbox?: boolean,
   slowMo?: number,
 };
 export type BrowserTypeLaunchOptions = {
@@ -206,6 +207,7 @@ export type BrowserTypeLaunchOptions = {
   },
   downloadsPath?: string,
   firefoxUserPrefs?: SerializedValue,
+  chromiumSandbox?: boolean,
   slowMo?: number,
 };
 export type BrowserTypeLaunchResult = {
@@ -234,6 +236,7 @@ export type BrowserTypeLaunchServerParams = {
   },
   downloadsPath?: string,
   firefoxUserPrefs?: SerializedValue,
+  chromiumSandbox?: boolean,
   port?: number,
 };
 export type BrowserTypeLaunchServerOptions = {
@@ -259,6 +262,7 @@ export type BrowserTypeLaunchServerOptions = {
   },
   downloadsPath?: string,
   firefoxUserPrefs?: SerializedValue,
+  chromiumSandbox?: boolean,
   port?: number,
 };
 export type BrowserTypeLaunchServerResult = {
@@ -287,6 +291,7 @@ export type BrowserTypeLaunchPersistentContextParams = {
     password?: string,
   },
   downloadsPath?: string,
+  chromiumSandbox?: boolean,
   slowMo?: number,
   noDefaultViewport?: boolean,
   viewport?: {
@@ -342,6 +347,7 @@ export type BrowserTypeLaunchPersistentContextOptions = {
     password?: string,
   },
   downloadsPath?: string,
+  chromiumSandbox?: boolean,
   slowMo?: number,
   noDefaultViewport?: boolean,
   viewport?: {
diff --git a/src/rpc/protocol.yml b/src/rpc/protocol.yml
index cb0f517856..32b5b29427 100644
--- a/src/rpc/protocol.yml
+++ b/src/rpc/protocol.yml
@@ -216,6 +216,7 @@ BrowserType:
             password: string?
         downloadsPath: string?
         firefoxUserPrefs: SerializedValue?
+        chromiumSandbox: boolean?
         slowMo: number?
       returns:
         browser: Browser
@@ -252,6 +253,7 @@ BrowserType:
             password: string?
         downloadsPath: string?
         firefoxUserPrefs: SerializedValue?
+        chromiumSandbox: boolean?
         port: number?
       returns:
         server: BrowserServer
@@ -288,6 +290,7 @@ BrowserType:
             username: string?
             password: string?
         downloadsPath: string?
+        chromiumSandbox: boolean?
         slowMo: number?
         noDefaultViewport: boolean?
         viewport:
diff --git a/src/rpc/validator.ts b/src/rpc/validator.ts
index d760365666..1ed318194a 100644
--- a/src/rpc/validator.ts
+++ b/src/rpc/validator.ts
@@ -128,6 +128,7 @@ export function createScheme(tChannel: (name: string) => Validator): Scheme {
     })),
     downloadsPath: tOptional(tString),
     firefoxUserPrefs: tOptional(tType('SerializedValue')),
+    chromiumSandbox: tOptional(tBoolean),
     slowMo: tOptional(tNumber),
   });
   scheme.BrowserTypeLaunchServerParams = tObject({
@@ -153,6 +154,7 @@ export function createScheme(tChannel: (name: string) => Validator): Scheme {
     })),
     downloadsPath: tOptional(tString),
     firefoxUserPrefs: tOptional(tType('SerializedValue')),
+    chromiumSandbox: tOptional(tBoolean),
     port: tOptional(tNumber),
   });
   scheme.BrowserTypeLaunchPersistentContextParams = tObject({
@@ -178,6 +180,7 @@ export function createScheme(tChannel: (name: string) => Validator): Scheme {
       password: tOptional(tString),
     })),
     downloadsPath: tOptional(tString),
+    chromiumSandbox: tOptional(tBoolean),
     slowMo: tOptional(tNumber),
     noDefaultViewport: tOptional(tBoolean),
     viewport: tOptional(tObject({