From 4ef22d338712f0183d052f88f7aba7d917d8442e Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Mon, 7 Feb 2022 16:09:11 -0800 Subject: [PATCH] test: enable "should record open in a new tab with url" on webkit (#11917) --- tests/inspector/cli-codegen-2.spec.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/inspector/cli-codegen-2.spec.ts b/tests/inspector/cli-codegen-2.spec.ts index a3ef05c898..5e750f54a4 100644 --- a/tests/inspector/cli-codegen-2.spec.ts +++ b/tests/inspector/cli-codegen-2.spec.ts @@ -364,8 +364,6 @@ test.describe('cli codegen', () => { }); test('should record open in a new tab with url', async ({ page, openRecorder, browserName, platform }) => { - test.fixme(browserName === 'webkit', 'Ctrl+click does not open in new tab on WebKit'); - const recorder = await openRecorder(); await recorder.setContentAndWait(`link`); @@ -375,7 +373,7 @@ test.describe('cli codegen', () => { await page.click('a', { modifiers: [ platform === 'darwin' ? 'Meta' : 'Control'] }); const sources = await recorder.waitForOutput('JavaScript', 'page1'); - if (browserName === 'chromium') { + if (browserName !== 'firefox') { expect(sources.get('JavaScript').text).toContain(` // Open new page const page1 = await context.newPage(); @@ -388,7 +386,7 @@ test.describe('cli codegen', () => { // Open new page var page1 = await context.NewPageAsync(); await page1.GotoAsync("about:blank?foo");`); - } else if (browserName === 'firefox') { + } else { expect(sources.get('JavaScript').text).toContain(` // Click text=link const [page1] = await Promise.all([