From 4efa9e5ea0bf9c55c22069f444ee768fa8590aa2 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Tue, 21 Feb 2023 23:49:14 +0100 Subject: [PATCH] test: unskip WK tests (#21033) Fixes https://github.com/microsoft/playwright/issues/20370 Fixes https://github.com/microsoft/playwright/issues/12353 --- tests/library/browsercontext-add-cookies.spec.ts | 3 +-- tests/library/capabilities.spec.ts | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/library/browsercontext-add-cookies.spec.ts b/tests/library/browsercontext-add-cookies.spec.ts index 185819c661..418967e439 100644 --- a/tests/library/browsercontext-add-cookies.spec.ts +++ b/tests/library/browsercontext-add-cookies.spec.ts @@ -454,8 +454,7 @@ it('should allow unnamed cookies', async ({ page, context, server, browserName, expect.soft(await page.evaluate('document.cookie')).toBe('unnamed-via-js'); }); -it('should set cookies on WebSocket', async ({ contextFactory, httpsServer, browserName, platform }) => { - it.fixme(browserName === 'webkit' && platform === 'win32', 'WebKit on win32 does not send any cookies over the WebSocket connection'); +it('should set secure cookies on secure WebSocket', async ({ contextFactory, httpsServer }) => { let resolveResceivedWebSocketHeaders = (headers: IncomingHttpHeaders) => { }; const receivedWebSocketHeaders = new Promise(resolve => resolveResceivedWebSocketHeaders = resolve); httpsServer.onceWebSocketConnection((ws, req) => resolveResceivedWebSocketHeaders(req.headers)); diff --git a/tests/library/capabilities.spec.ts b/tests/library/capabilities.spec.ts index 5bcdcdee17..8e0048a848 100644 --- a/tests/library/capabilities.spec.ts +++ b/tests/library/capabilities.spec.ts @@ -168,15 +168,14 @@ it('should not crash on storage.getDirectory()', async ({ page, server, browserN } }); -it('navigator.clipboard should be present', async ({ page, server, browserName, browserMajorVersion }) => { +it('navigator.clipboard should be present', async ({ page, server }) => { it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/18901' }); await page.goto(server.EMPTY_PAGE); expect(await page.evaluate(() => navigator.clipboard)).toBeTruthy(); }); -it('should set CloseEvent.wasClean to false when the server terminates a WebSocket connection', async ({ page, server, browserName, platform }) => { +it('should set CloseEvent.wasClean to false when the server terminates a WebSocket connection', async ({ page, server }) => { it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/12353' }); - it.fixme(browserName === 'webkit' && platform === 'win32'); server.onceWebSocketConnection(socket => { socket.terminate(); });