Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore(bidi): Fix handling of cookie headers in network.continueRequest (#34277)

Browse source
This commit is contained in:
Julian Descottes 2025-01-10 20:06:26 +01:00 committed by GitHub
parent ca94291ab7
commit 4f3a5e2133
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/playwright-core/src/server/bidi/bidiNetworkManager.ts
View file

@ -306,11 +306,9 @@ function fromBidiHeaders(bidiHeaders: bidi.Network.Header[]): types.HeadersArray
return result;
}
function toBidiRequestHeaders(allHeaders: types.HeadersArray): { cookies: bidi.Network.CookieHeader[], headers: bidi.Network.Header[] } {
function toBidiRequestHeaders(allHeaders: types.HeadersArray): { headers: bidi.Network.Header[] } {
const bidiHeaders = toBidiHeaders(allHeaders);
const cookies = bidiHeaders.filter(h => h.name.toLowerCase() === 'cookie');
const headers = bidiHeaders.filter(h => h.name.toLowerCase() !== 'cookie');
return { cookies, headers };
return { headers: bidiHeaders };
}
function toBidiResponseHeaders(headers: types.HeadersArray): { cookies: bidi.Network.SetCookieHeader[], headers: bidi.Network.Header[] } {

2
tests/page/page-route.spec.ts
View file

@ -167,7 +167,7 @@ it('should properly return navigation response when URL has cookies', async ({ p
it('should override cookie header', async ({ page, server, browserName }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/16773' });
it.fail(browserName !== 'firefox');
it.fail(browserName !== 'firefox' && !browserName.includes('bidi'));
await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => document.cookie = 'original=value');