Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(chromium): make locale overrides work (#1108)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-02-26 11:01:46 -08:00 committed by GitHub
parent 3afaeef557
commit 4f69930fbe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/chromium/crPage.ts
View file

@ -112,6 +112,8 @@ export class CRPage implements PageDelegate {
promises.push(this._client.send('Emulation.setScriptExecutionDisabled', { value: true })); promises.push(this._client.send('Emulation.setScriptExecutionDisabled', { value: true }));
if (options.userAgent || options.locale) if (options.userAgent || options.locale)
promises.push(this._client.send('Emulation.setUserAgentOverride', { userAgent: options.userAgent || '', acceptLanguage: options.locale })); promises.push(this._client.send('Emulation.setUserAgentOverride', { userAgent: options.userAgent || '', acceptLanguage: options.locale }));
if (options.locale)
promises.push(this._client.send('Emulation.setLocaleOverride', { locale: options.locale }));
if (options.timezoneId) if (options.timezoneId)
promises.push(emulateTimezone(this._client, options.timezoneId)); promises.push(emulateTimezone(this._client, options.timezoneId));
if (options.geolocation) if (options.geolocation)

2
test/emulation.spec.js
View file

@ -253,7 +253,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF
}); });
}); });
describe.skip(CHROMIUM || FFOX)('BrowserContext({locale})', function() { describe.skip(FFOX)('BrowserContext({locale})', function() {
it('should affect accept-language header', async({browser, server}) => { it('should affect accept-language header', async({browser, server}) => {
const context = await browser.newContext({ locale: 'fr-CH' }); const context = await browser.newContext({ locale: 'fr-CH' });
const page = await context.newPage(); const page = await context.newPage();