From 4f7d65fe9c6ff8cf80dc4c8993eda043e28c0171 Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Mon, 19 Oct 2020 02:23:53 -0700 Subject: [PATCH] browser(firefox): report pageerrors without stack properties (#4166) --- browser_patches/firefox/BUILD_NUMBER | 4 ++-- browser_patches/firefox/juggler/content/PageAgent.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/browser_patches/firefox/BUILD_NUMBER b/browser_patches/firefox/BUILD_NUMBER index bde01197c5..52fbedfa71 100644 --- a/browser_patches/firefox/BUILD_NUMBER +++ b/browser_patches/firefox/BUILD_NUMBER @@ -1,2 +1,2 @@ -1193 -Changed: joel.einbinder@gmail.com Fri 16 Oct 2020 01:22:55 AM PDT +1194 +Changed: joel.einbinder@gmail.com Fri 16 Oct 2020 01:52:53 AM PDT diff --git a/browser_patches/firefox/juggler/content/PageAgent.js b/browser_patches/firefox/juggler/content/PageAgent.js index 29992afcb1..3e1afbb56d 100644 --- a/browser_patches/firefox/juggler/content/PageAgent.js +++ b/browser_patches/firefox/juggler/content/PageAgent.js @@ -375,7 +375,7 @@ class PageAgent { this._browserPage.emit('pageUncaughtError', { frameId: frame.id(), message: errorEvent.message, - stack: errorEvent.error ? errorEvent.error.stack : '', + stack: errorEvent.error && typeof errorEvent.error.stack === 'string' ? errorEvent.error.stack : '', }); }