Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: uncomment more cookies tests

Browse source
This commit is contained in:
Pavel Feldman 2019-12-02 17:02:33 -08:00
parent 8989da6c16
commit 505c9e3660
2 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/webkit/Browser.ts
View file

@ -24,6 +24,7 @@ import { Events } from './events';
import { Page, Viewport } from './Page'; import { Page, Viewport } from './Page';
import { Target } from './Target'; import { Target } from './Target';
import { TaskQueue } from './TaskQueue'; import { TaskQueue } from './TaskQueue';
import { Protocol } from './protocol';
export class Browser extends EventEmitter { export class Browser extends EventEmitter {
_defaultViewport: Viewport; _defaultViewport: Viewport;
@ -272,7 +273,7 @@ export class BrowserContext extends EventEmitter {
async setCookies(cookies: SetNetworkCookieParam[]) { async setCookies(cookies: SetNetworkCookieParam[]) {
cookies = rewriteCookies(cookies); cookies = rewriteCookies(cookies);
const cc = cookies.map(c => ({ ...c, session: c.expires === -1 || c.expires === undefined })); const cc = cookies.map(c => ({ ...c, session: c.expires === -1 || c.expires === undefined })) as Protocol.Browser.SetCookieParam[];
await this._browser._connection.send('Browser.setCookies', { cookies: cc, browserContextId: this._id }); await this._browser._connection.send('Browser.setCookies', { cookies: cc, browserContextId: this._id });
} }

8
test/defaultbrowsercontext.spec.js
View file

@ -14,7 +14,7 @@
* limitations under the License. * limitations under the License.
*/ */
module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, playwright, FFOX, CHROME, WEBKIT}) { module.exports.addTests = function ({ testRunner, expect, defaultBrowserOptions, playwright }) {
const {describe, xdescribe, fdescribe} = testRunner; const {describe, xdescribe, fdescribe} = testRunner;
const {it, fit, xit} = testRunner; const {it, fit, xit} = testRunner;
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
@ -40,14 +40,13 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p
domain: 'localhost', domain: 'localhost',
path: '/', path: '/',
expires: -1, expires: -1,
size: 16,
httpOnly: false, httpOnly: false,
secure: false, secure: false,
session: true, session: true,
sameSite: 'None', sameSite: 'None',
}]); }]);
}); });
it.skip(WEBKIT)('context.setCookies() should work', async({page, server}) => { it('context.setCookies() should work', async({page, server}) => {
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
await page.browserContext().setCookies([{ await page.browserContext().setCookies([{
url: server.EMPTY_PAGE, url: server.EMPTY_PAGE,
@ -61,14 +60,13 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p
domain: 'localhost', domain: 'localhost',
path: '/', path: '/',
expires: -1, expires: -1,
size: 16,
httpOnly: false, httpOnly: false,
secure: false, secure: false,
session: true, session: true,
sameSite: 'None', sameSite: 'None',
}]); }]);
}); });
it.skip(WEBKIT)('context.clearCookies() should work', async({page, server}) => { it('context.clearCookies() should work', async({page, server}) => {
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
await page.browserContext().setCookies([{ await page.browserContext().setCookies([{
url: server.EMPTY_PAGE, url: server.EMPTY_PAGE,