Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(chromium): disable ThirdPartyStoragePartitioning (#32701)

Browse source 
See
https://developers.google.com/privacy-sandbox/cookies/storage-partitioning
for more details.

References #32230.
This commit is contained in:
Dmitry Gozman 2024-09-19 03:12:21 -07:00 committed by GitHub
parent 61cbca6695
commit 5089d9f293
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 47 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/playwright-core/src/server/chromium/chromiumSwitches.ts
View file

@ -36,7 +36,8 @@ export const chromiumSwitches = [
// HttpsUpgrades - https://github.com/microsoft/playwright/pull/27605
// PaintHolding - https://github.com/microsoft/playwright/issues/28023
// PlzDedicatedWorker - https://github.com/microsoft/playwright/issues/31747
'--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync,Translate,HttpsUpgrades,PaintHolding,PlzDedicatedWorker',
// ThirdPartyStoragePartitioning - https://github.com/microsoft/playwright/issues/32230
'--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync,Translate,HttpsUpgrades,PaintHolding,PlzDedicatedWorker,ThirdPartyStoragePartitioning',
'--allow-pre-commit-input',
'--disable-hang-monitor',
'--disable-ipc-flooding-protection',

45
tests/library/browsercontext-storage-state.spec.ts
View file

@ -15,6 +15,7 @@
* limitations under the License.
*/
import { attachFrame } from 'tests/config/utils';
import { browserTest as it, expect } from '../config/browserTest';
import fs from 'fs';
@ -275,3 +276,47 @@ it('should work when service worker is intefering', async ({ page, context, serv
const storageState = await context.storageState();
expect(storageState.origins[0].localStorage[0]).toEqual({ name: 'foo', value: 'bar' });
});
it('should set local storage in third-party context', async ({ contextFactory, server, browserName }) => {
it.fixme(browserName === 'webkit', 'look into setStorageBlockingPolicy');
const context = await contextFactory({
storageState: {
cookies: [],
origins: [
{
origin: server.CROSS_PROCESS_PREFIX,
localStorage: [{
name: 'name1',
value: 'value1'
}]
},
]
}
});
const page = await context.newPage();
await page.goto(server.EMPTY_PAGE);
const frame = await attachFrame(page, 'frame1', server.CROSS_PROCESS_PREFIX + '/empty.html');
const localStorage = await frame.evaluate('window.localStorage');
expect(localStorage).toEqual({ name1: 'value1' });
await context.close();
});
it('should roundtrip local storage in third-party context', async ({ page, contextFactory, server, browserName }) => {
it.fixme(browserName === 'webkit', 'look into setStorageBlockingPolicy');
await page.goto(server.EMPTY_PAGE);
const frame = await attachFrame(page, 'frame1', server.CROSS_PROCESS_PREFIX + '/empty.html');
await frame.evaluate(() => window.localStorage.setItem('name1', 'value1'));
const storageState = await page.context().storageState();
const context2 = await contextFactory({ storageState });
const page2 = await context2.newPage();
await page2.goto(server.EMPTY_PAGE);
const frame2 = await attachFrame(page2, 'frame1', server.CROSS_PROCESS_PREFIX + '/empty.html');
const localStorage = await frame2.evaluate('window.localStorage');
expect(localStorage).toEqual({ name1: 'value1' });
await context2.close();
});