Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(#34524): chore: allow repetative application of rebaselines in the same session

Browse source
This commit is contained in:
Pavel Feldman 2025-01-28 14:37:47 -08:00
parent 0213cf57bd
commit 50a58f992b
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/playwright/src/runner/rebase.ts
View file

@ -43,6 +43,10 @@ export function addSuggestedRebaseline(location: Location, suggestedRebaseline:
suggestedRebaselines.set(location.file, { location, code: suggestedRebaseline }); suggestedRebaselines.set(location.file, { location, code: suggestedRebaseline });
} }
export function clearSuggestedRebaselines() {
suggestedRebaselines.clear();
}
export async function applySuggestedRebaselines(config: FullConfigInternal, reporter: InternalReporter) { export async function applySuggestedRebaselines(config: FullConfigInternal, reporter: InternalReporter) {
if (config.config.updateSnapshots === 'none') if (config.config.updateSnapshots === 'none')
return; return;

5
packages/playwright/src/runner/tasks.ts
View file

@ -34,7 +34,7 @@ import { detectChangedTestFiles } from './vcs';
import type { InternalReporter } from '../reporters/internalReporter'; import type { InternalReporter } from '../reporters/internalReporter';
import { cacheDir } from '../transform/compilationCache'; import { cacheDir } from '../transform/compilationCache';
import type { FullResult } from '../../types/testReporter'; import type { FullResult } from '../../types/testReporter';
import { applySuggestedRebaselines } from './rebase'; import { applySuggestedRebaselines, clearSuggestedRebaselines } from './rebase';
const readDirAsync = promisify(fs.readdir); const readDirAsync = promisify(fs.readdir);
@ -284,6 +284,9 @@ export function createLoadTask(mode: 'out-of-process' | 'in-process', options: {
export function createApplyRebaselinesTask(): Task<TestRun> { export function createApplyRebaselinesTask(): Task<TestRun> {
return { return {
title: 'apply rebaselines', title: 'apply rebaselines',
setup: async () => {
clearSuggestedRebaselines();
},
teardown: async ({ config, reporter }) => { teardown: async ({ config, reporter }) => {
await applySuggestedRebaselines(config, reporter); await applySuggestedRebaselines(config, reporter);
}, },