From 50a6ba7fdc437bfc9ef8f2c40cd7e9e6ddee7980 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 23 Oct 2020 10:33:58 -0700 Subject: [PATCH] feat: bump webkit version to include screencast fixes (#4200) --- browsers.json | 2 +- test/screencast.spec.ts | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/browsers.json b/browsers.json index 5af39f2e3b..ff85231b8d 100644 --- a/browsers.json +++ b/browsers.json @@ -13,7 +13,7 @@ }, { "name": "webkit", - "revision": "1363", + "revision": "1364", "download": true } ] diff --git a/test/screencast.spec.ts b/test/screencast.spec.ts index 09cf1cde62..947fac4816 100644 --- a/test/screencast.spec.ts +++ b/test/screencast.spec.ts @@ -40,7 +40,9 @@ export class VideoPlayer { constructor(fileName: string) { this.fileName = fileName; - this.output = spawnSync(ffmpeg, ['-i', this.fileName, `${this.fileName}-%03d.png`]).stderr.toString(); + // Force output frame rate to 25 fps as otherwise it would produce one image per timebase unit + // which is 1 / (25 * 1000). + this.output = spawnSync(ffmpeg, ['-i', this.fileName, '-r', '25', `${this.fileName}-%03d.png`]).stderr.toString(); const lines = this.output.split('\n'); let framesLine = lines.find(l => l.startsWith('frame='))!; @@ -123,7 +125,7 @@ function expectAll(pixels: Buffer, rgbaPredicate) { checkPixel(i); } catch (e) { // Log pixel values on failure. - e.message += `\n\nActual pixels=[${pixels}]`; + e.message += `\n\nActual pixels=[${pixels.join(',')}]`; throw e; } }