Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: add a test for arbitrary options (#2977)

Browse source 
We should be able to accept unexpected properties in options objects.
This commit is contained in:
Dmitry Gozman 2020-07-16 12:21:36 -07:00 committed by GitHub
parent ecc130c644
commit 513899a3b9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
test/launcher.spec.js
View file

@ -18,7 +18,7 @@
const path = require('path'); const path = require('path');
const fs = require('fs'); const fs = require('fs');
const utils = require('./utils'); const utils = require('./utils');
const {FFOX, CHROMIUM, WEBKIT, WIN, USES_HOOKS} = utils.testOptions(browserType); const {FFOX, CHROMIUM, WEBKIT, WIN, USES_HOOKS, CHANNEL} = utils.testOptions(browserType);
describe('Playwright', function() { describe('Playwright', function() {
describe('browserType.launch', function() { describe('browserType.launch', function() {
@ -75,6 +75,10 @@ describe('Playwright', function() {
const error = await browserType.launch(options).catch(e => e); const error = await browserType.launch(options).catch(e => e);
expect(error.message).toContain('<launching>'); expect(error.message).toContain('<launching>');
}); });
it.slow().skip(CHANNEL)('should accept objects as options', async({browserType, defaultBrowserOptions}) => {
const browser = await browserType.launch({ ...defaultBrowserOptions, process });
await browser.close();
});
}); });
describe('browserType.launchServer', function() { describe('browserType.launchServer', function() {