Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

devops: support npx playwright install --with-deps command (#7194)

Browse source 
The common pattern today is to have two commands to configure CI:

```sh
npx playwright install-deps chromium
npx playwright install chromium
```

With this patch, this becomes:

```sh
npx playwright install --with-deps chromium
```

Note: `--with-deps` might call `sudo`.
This commit is contained in:
Andrey Lushnikov 2021-08-07 13:53:33 +03:00 committed by GitHub
parent 559d6242f0
commit 51fb19561c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 47 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.github/workflows/tests_fyi.yml vendored
View file

@ -27,8 +27,9 @@ jobs:
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps ${{ matrix.browser }} chromium - run: node lib/cli/cli install --with-deps ${{ matrix.browser }} chromium
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }} - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }}
env: env:
PWTEST_VIDEO: 1 PWTEST_VIDEO: 1

6
.github/workflows/tests_primary.yml vendored
View file

@ -35,8 +35,9 @@ jobs:
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps ${{ matrix.browser }} chromium - run: node lib/cli/cli install --with-deps ${{ matrix.browser }} chromium
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }} - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }}
- run: node tests/config/checkCoverage.js ${{ matrix.browser }} - run: node tests/config/checkCoverage.js ${{ matrix.browser }}
- run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
@ -63,6 +64,5 @@ jobs:
env: env:
DEBUG: pw:install DEBUG: pw:install
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps - run: node lib/cli/cli install --with-deps
- run: node lib/cli/cli install
- run: npm run ttest - run: npm run ttest

57
.github/workflows/tests_secondary.yml vendored
View file

@ -36,8 +36,9 @@ jobs:
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps ${{ matrix.browser }} chromium - run: node lib/cli/cli install --with-deps ${{ matrix.browser }} chromium
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }} - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }}
- run: node tests/config/checkCoverage.js ${{ matrix.browser }} - run: node tests/config/checkCoverage.js ${{ matrix.browser }}
- run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
@ -64,8 +65,9 @@ jobs:
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps ${{ matrix.browser }} chromium - run: node lib/cli/cli install --with-deps ${{ matrix.browser }} chromium
- run: npm run test -- --project=${{ matrix.browser }} - run: npm run test -- --project=${{ matrix.browser }}
- run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
if: always() if: always()
@ -90,8 +92,9 @@ jobs:
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps - run: node lib/cli/cli install --with-deps ${{ matrix.browser }} chromium
- run: npm run test -- --project=${{ matrix.browser }} - run: npm run test -- --project=${{ matrix.browser }}
shell: bash shell: bash
- run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
@ -140,8 +143,9 @@ jobs:
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps ${{ matrix.browser }} chromium - run: node lib/cli/cli install --with-deps ${{ matrix.browser }} chromium
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }} - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }}
if: ${{ always() }} if: ${{ always() }}
env: env:
@ -169,8 +173,9 @@ jobs:
- run: npm ci - run: npm ci
env: env:
DEBUG: pw:install DEBUG: pw:install
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps chromium - run: node lib/cli/cli install --with-deps chromium
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ctest - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ctest
env: env:
PWTEST_MODE: ${{ matrix.mode }} PWTEST_MODE: ${{ matrix.mode }}
@ -194,8 +199,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps chromium - run: node lib/cli/cli install --with-deps chrome
- run: node lib/cli/cli install chrome
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ctest - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ctest
env: env:
PWTEST_CHANNEL: chrome PWTEST_CHANNEL: chrome
@ -219,7 +223,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install chrome - run: node lib/cli/cli install --with-deps chrome
- run: npm run ctest - run: npm run ctest
shell: bash shell: bash
env: env:
@ -245,7 +249,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install chrome - run: node lib/cli/cli install --with-deps chrome
- run: npm run ctest - run: npm run ctest
env: env:
PWTEST_CHANNEL: chrome PWTEST_CHANNEL: chrome
@ -269,8 +273,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps firefox - run: node lib/cli/cli install --with-deps firefox-beta chromium
- run: node lib/cli/cli install firefox-beta chromium
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ftest - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ftest
env: env:
PWTEST_CHANNEL: firefox-beta PWTEST_CHANNEL: firefox-beta
@ -294,8 +297,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps chromium - run: node lib/cli/cli install --with-deps firefox-beta chromium
- run: node lib/cli/cli install firefox-beta chromium
- run: npm run ftest - run: npm run ftest
shell: bash shell: bash
env: env:
@ -321,7 +323,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install firefox-beta chromium - run: node lib/cli/cli install --with-deps firefox-beta chromium
- run: npm run ftest - run: npm run ftest
env: env:
PWTEST_CHANNEL: firefox-beta PWTEST_CHANNEL: firefox-beta
@ -345,7 +347,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install msedge - run: node lib/cli/cli install --with-deps msedge
- run: npm run ctest - run: npm run ctest
env: env:
PWTEST_CHANNEL: msedge PWTEST_CHANNEL: msedge
@ -370,7 +372,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install msedge - run: node lib/cli/cli install --with-deps msedge
- run: npm run ctest - run: npm run ctest
shell: bash shell: bash
env: env:
@ -393,7 +395,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install msedge-beta - run: node lib/cli/cli install --with-deps msedge-beta
- run: npm run ctest - run: npm run ctest
env: env:
PWTEST_CHANNEL: msedge-beta PWTEST_CHANNEL: msedge-beta
@ -417,7 +419,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install msedge-beta - run: node lib/cli/cli install --with-deps msedge-beta
- run: npm run ctest - run: npm run ctest
shell: bash shell: bash
env: env:
@ -440,7 +442,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install msedge-beta - run: node lib/cli/cli install --with-deps msedge-beta
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ctest - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ctest
env: env:
PWTEST_CHANNEL: msedge-beta PWTEST_CHANNEL: msedge-beta
@ -464,7 +466,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install msedge-dev - run: node lib/cli/cli install --with-deps msedge-dev
- run: npm run ctest - run: npm run ctest
env: env:
PWTEST_CHANNEL: msedge-dev PWTEST_CHANNEL: msedge-dev
@ -488,7 +490,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install msedge-dev - run: node lib/cli/cli install --with-deps msedge-dev
- run: npm run ctest - run: npm run ctest
shell: bash shell: bash
env: env:
@ -511,7 +513,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install msedge-dev - run: node lib/cli/cli install --with-deps msedge-dev
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ctest - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ctest
env: env:
PWTEST_CHANNEL: msedge-dev PWTEST_CHANNEL: msedge-dev
@ -535,8 +537,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps chromium - run: node lib/cli/cli install --with-deps chrome-beta
- run: node lib/cli/cli install chrome-beta
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ctest - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run ctest
env: env:
PWTEST_CHANNEL: chrome-beta PWTEST_CHANNEL: chrome-beta
@ -560,7 +561,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install chrome-beta - run: node lib/cli/cli install --with-deps chrome-beta
- run: npm run ctest - run: npm run ctest
shell: bash shell: bash
env: env:
@ -586,7 +587,7 @@ jobs:
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install chrome-beta - run: node lib/cli/cli install --with-deps chrome-beta
- run: npm run ctest - run: npm run ctest
env: env:
PWTEST_CHANNEL: chrome-beta PWTEST_CHANNEL: chrome-beta
@ -607,8 +608,10 @@ jobs:
with: with:
node-version: 12 node-version: 12
- run: npm ci - run: npm ci
env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
- run: npm run build - run: npm run build
- run: node lib/cli/cli install-deps chromium - run: node lib/cli/cli install --with-deps chromium
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run etest - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run etest
- run: node tests/config/checkCoverage.js electron - run: node tests/config/checkCoverage.js electron
- run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json

17
src/cli/cli.ts
View file

@ -86,7 +86,7 @@ function suggestedBrowsersToInstall() {
return registry.executables().filter(e => e.installType !== 'none' && e.type !== 'tool').map(e => e.name).join(', '); return registry.executables().filter(e => e.installType !== 'none' && e.type !== 'tool').map(e => e.name).join(', ');
} }
function checkBrowsersToInstall(args: string[]) { function checkBrowsersToInstall(args: string[]): Executable[] {
const faultyArguments: string[] = []; const faultyArguments: string[] = [];
const executables: Executable[] = []; const executables: Executable[] = [];
for (const arg of args) { for (const arg of args) {
@ -106,12 +106,19 @@ function checkBrowsersToInstall(args: string[]) {
program program
.command('install [browser...]') .command('install [browser...]')
.description('ensure browsers necessary for this version of Playwright are installed') .description('ensure browsers necessary for this version of Playwright are installed')
.action(async function(args: string[]) { .option('--with-deps', 'install system dependencies for browsers')
.action(async function(args: string[], command: program.Command) {
try { try {
if (!args.length) if (!args.length) {
if (command.opts().withDeps)
await registry.installDeps();
await registry.install(); await registry.install();
else } else {
await registry.install(checkBrowsersToInstall(args)); const executables = checkBrowsersToInstall(args);
if (command.opts().withDeps)
await registry.installDeps(executables);
await registry.install(executables);
}
} catch (e) { } catch (e) {
console.log(`Failed to install browsers\n${e}`); console.log(`Failed to install browsers\n${e}`);
process.exit(1); process.exit(1);