Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: remove unused request param from route.continue (#32307)

Browse source
This commit is contained in:
Yury Semikhatsky 2024-08-28 08:24:44 -07:00 committed by GitHub
parent d61b207ce3
commit 5271fe1f26
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/chromium/crNetworkManager.ts
View file

@ -609,7 +609,7 @@ class RouteImpl implements network.RouteDelegate {
this._interceptionId = interceptionId; this._interceptionId = interceptionId;
} }
async continue(request: network.Request, overrides: types.NormalizedContinueOverrides): Promise<void> { async continue(overrides: types.NormalizedContinueOverrides): Promise<void> {
this._alreadyContinuedParams = { this._alreadyContinuedParams = {
requestId: this._interceptionId!, requestId: this._interceptionId!,
url: overrides.url, url: overrides.url,

2
packages/playwright-core/src/server/firefox/ffNetworkManager.ts
View file

@ -226,7 +226,7 @@ class FFRouteImpl implements network.RouteDelegate {
this._request = request; this._request = request;
} }
async continue(request: network.Request, overrides: types.NormalizedContinueOverrides) { async continue(overrides: types.NormalizedContinueOverrides) {
await this._session.sendMayFail('Network.resumeInterceptedRequest', { await this._session.sendMayFail('Network.resumeInterceptedRequest', {
requestId: this._request._id, requestId: this._request._id,
url: overrides.url, url: overrides.url,

3
packages/playwright-core/src/server/frames.ts
View file

@ -291,8 +291,7 @@ export class FrameManager {
if (request._documentId) if (request._documentId)
frame.setPendingDocument({ documentId: request._documentId, request }); frame.setPendingDocument({ documentId: request._documentId, request });
if (request._isFavicon) { if (request._isFavicon) {
if (route) route?.continue({ isFallback: true }).catch(() => {});
route.continue(request, { isFallback: true }).catch(() => {});
return; return;
} }
this._page.emitOnContext(BrowserContext.Events.Request, request); this._page.emitOnContext(BrowserContext.Events.Request, request);

4
packages/playwright-core/src/server/network.ts
View file

@ -324,7 +324,7 @@ export class Route extends SdkObject {
this._request._setOverrides(overrides); this._request._setOverrides(overrides);
if (!overrides.isFallback) if (!overrides.isFallback)
this._request._context.emit(BrowserContext.Events.RequestContinued, this._request); this._request._context.emit(BrowserContext.Events.RequestContinued, this._request);
await this._delegate.continue(this._request, overrides); await this._delegate.continue(overrides);
this._endHandling(); this._endHandling();
} }
@ -612,7 +612,7 @@ export class WebSocket extends SdkObject {
export interface RouteDelegate { export interface RouteDelegate {
abort(errorCode: string): Promise<void>; abort(errorCode: string): Promise<void>;
fulfill(response: types.NormalizedFulfillResponse): Promise<void>; fulfill(response: types.NormalizedFulfillResponse): Promise<void>;
continue(request: Request, overrides: types.NormalizedContinueOverrides): Promise<void>; continue(overrides: types.NormalizedContinueOverrides): Promise<void>;
} }
// List taken from https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml with extra 306 and 418 codes. // List taken from https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml with extra 306 and 418 codes.

2
packages/playwright-core/src/server/webkit/wkInterceptableRequest.ts
View file

@ -141,7 +141,7 @@ export class WKRouteImpl implements network.RouteDelegate {
}); });
} }
async continue(request: network.Request, overrides: types.NormalizedContinueOverrides) { async continue(overrides: types.NormalizedContinueOverrides) {
// In certain cases, protocol will return error if the request was already canceled // In certain cases, protocol will return error if the request was already canceled
// or the page was closed. We should tolerate these errors. // or the page was closed. We should tolerate these errors.
await this._session.sendMayFail('Network.interceptWithRequest', { await this._session.sendMayFail('Network.interceptWithRequest', {