From 5274f2bd3cfef11700881dac4420621452db3c6b Mon Sep 17 00:00:00 2001 From: Pavel Date: Fri, 6 Dec 2019 17:37:45 -0800 Subject: [PATCH] chore: only test request interception for Chrome & FF --- test/playwright.spec.js | 6 +++++- test/requestinterception.spec.js | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/test/playwright.spec.js b/test/playwright.spec.js index ee1ff51f78..53cb1a0874 100644 --- a/test/playwright.spec.js +++ b/test/playwright.spec.js @@ -147,7 +147,6 @@ module.exports.addTests = ({testRunner, product, playwrightPath}) => { require('./network.spec.js').addTests(testOptions); require('./page.spec.js').addTests(testOptions); require('./queryselector.spec.js').addTests(testOptions); - require('./requestinterception.spec.js').addTests(testOptions); require('./screenshot.spec.js').addTests(testOptions); require('./waittask.spec.js').addTests(testOptions); @@ -162,6 +161,11 @@ module.exports.addTests = ({testRunner, product, playwrightPath}) => { require('./chromium/session.spec.js').addTests(testOptions); require('./chromium/workers.spec.js').addTests(testOptions); } + + if (CHROME || FFOX) { + require('./requestinterception.spec.js').addTests(testOptions); + } + }); // Browser-level tests that are given a browser. diff --git a/test/requestinterception.spec.js b/test/requestinterception.spec.js index 6232820ce3..0faaff9931 100644 --- a/test/requestinterception.spec.js +++ b/test/requestinterception.spec.js @@ -23,7 +23,7 @@ module.exports.addTests = function({testRunner, expect, FFOX, CHROME, WEBKIT}) { const {it, fit, xit} = testRunner; const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; - describe.skip(WEBKIT)('Interception.enable', function() { + describe('Interception.enable', function() { it('should intercept', async({page, server}) => { await page.interception.enable(); page.on('request', request => { @@ -275,7 +275,7 @@ module.exports.addTests = function({testRunner, expect, FFOX, CHROME, WEBKIT}) { return e.message; } }); - if (CHROME || WEBKIT) + if (CHROME) expect(result).toContain('Failed to fetch'); else expect(result).toContain('NetworkError');