Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix project filter test

Browse source
This commit is contained in:
Simon Knott 2024-09-16 10:47:51 +02:00
parent b4707ca82e
commit 52a6bdb803
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/playwright/src/runner/watchMode.ts
View file

@ -119,7 +119,7 @@ export async function runWatchModeLoop(configLocation: ConfigLocation, initialOp
} }
changedFiles.clear(); changedFiles.clear();
if (dirtyTestIds.size > 0) { if (dirtyTestIds.size > 0) {
onDirtyTests.resolve('changed'); onDirtyTests.resolve('changed');
onDirtyTests = new ManualPromise(); onDirtyTests = new ManualPromise();
} }
@ -144,10 +144,9 @@ export async function runWatchModeLoop(configLocation: ConfigLocation, initialOp
else else
printPrompt(); printPrompt();
const readCommandPromise = readCommand();
const command = await Promise.race([ const command = await Promise.race([
onDirtyTests, onDirtyTests,
readCommandPromise, readCommand(),
]); ]);
if (bufferMode && command === 'changed') if (bufferMode && command === 'changed')

5
tests/playwright-test/watch.spec.ts
View file

@ -313,12 +313,17 @@ test('should respect project filter C', async ({ runWatchTest, writeFiles }) =>
await testProcess.waitForOutput('[foo] › a.test.ts:3:11 › passes'); await testProcess.waitForOutput('[foo] › a.test.ts:3:11 › passes');
expect(testProcess.output).not.toContain('[bar] › a.test.ts:3:11 › passes'); expect(testProcess.output).not.toContain('[bar] › a.test.ts:3:11 › passes');
await testProcess.waitForOutput('Waiting for file changes.');
testProcess.clearOutput(); testProcess.clearOutput();
await writeFiles(files); // file change triggers listTests with project filter await writeFiles(files); // file change triggers listTests with project filter
await testProcess.waitForOutput('[foo] › a.test.ts:3:11 › passes'); await testProcess.waitForOutput('[foo] › a.test.ts:3:11 › passes');
testProcess.clearOutput();
await testProcess.waitForOutput('Waiting for file changes.');
testProcess.write('c'); testProcess.write('c');
testProcess.clearOutput();
await testProcess.waitForOutput('Select projects'); await testProcess.waitForOutput('Select projects');
await testProcess.waitForOutput('foo'); await testProcess.waitForOutput('foo');
await testProcess.waitForOutput('bar'); // second selection should still show all await testProcess.waitForOutput('bar'); // second selection should still show all