From 5327b8ca6d1c6e82bc8e385a12c916e473b89eb3 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Fri, 13 Aug 2021 08:29:25 -0700 Subject: [PATCH] feat(firefox): bump firefox to 1283, firefox-beta to 1277 (#8184) --- browsers.json | 4 ++-- src/server/firefox/ffBrowser.ts | 6 ++++-- src/server/firefox/protocol.d.ts | 8 +++++--- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/browsers.json b/browsers.json index f93abb5b69..3fffae1e29 100644 --- a/browsers.json +++ b/browsers.json @@ -13,12 +13,12 @@ }, { "name": "firefox", - "revision": "1282", + "revision": "1283", "installByDefault": true }, { "name": "firefox-beta", - "revision": "1276", + "revision": "1277", "installByDefault": false }, { diff --git a/src/server/firefox/ffBrowser.ts b/src/server/firefox/ffBrowser.ts index b815b95589..2310f3f1b6 100644 --- a/src/server/firefox/ffBrowser.ts +++ b/src/server/firefox/ffBrowser.ts @@ -207,8 +207,10 @@ export class FFBrowserContext extends BrowserContext { promises.push(this._ensureVideosPath().then(() => { return this._browser._connection.send('Browser.setVideoRecordingOptions', { // validateBrowserContextOptions ensures correct video size. - ...this._options.recordVideo!.size!, - dir: this._options.recordVideo!.dir, + options: { + ...this._options.recordVideo!.size!, + dir: this._options.recordVideo!.dir, + }, browserContextId: this._browserContextId }); })); diff --git a/src/server/firefox/protocol.d.ts b/src/server/firefox/protocol.d.ts index 28b1cea092..b3789fcca0 100644 --- a/src/server/firefox/protocol.d.ts +++ b/src/server/firefox/protocol.d.ts @@ -283,9 +283,11 @@ export module Protocol { export type setForcedColorsReturnValue = void; export type setVideoRecordingOptionsParameters = { browserContextId?: string; - dir: string; - width: number; - height: number; + options?: { + dir: string; + width: number; + height: number; + }; }; export type setVideoRecordingOptionsReturnValue = void; export type cancelDownloadParameters = {