Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(downloads): fix acceptDownloads complaint (#1777) (#1923)

Browse source
This commit is contained in:
Ross Wollman 2020-04-22 17:02:15 -07:00 committed by GitHub
parent 00e8d88777
commit 53c78a8a29
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/download.ts
View file

@ -39,9 +39,9 @@ export class Download {
this._url = url; this._url = url;
this._finishedCallback = () => {}; this._finishedCallback = () => {};
this._finishedPromise = new Promise(f => this._finishedCallback = f); this._finishedPromise = new Promise(f => this._finishedCallback = f);
this._page.emit(Events.Page.Download, this);
page._browserContext._downloads.add(this); page._browserContext._downloads.add(this);
this._acceptDownloads = !!this._page._browserContext._options.acceptDownloads; this._acceptDownloads = !!this._page._browserContext._options.acceptDownloads;
this._page.emit(Events.Page.Download, this);
} }
url(): string { url(): string {

13
test/download.spec.js
View file

@ -70,6 +70,19 @@ describe('Download', function() {
expect(fs.readFileSync(path).toString()).toBe('Hello world'); expect(fs.readFileSync(path).toString()).toBe('Hello world');
await page.close(); await page.close();
}); });
it(`should report download path within page.on('download', …) handler`, async({browser, server}) => {
const page = await browser.newPage({ acceptDownloads: true });
const onDownloadPathPath = new Promise((res) => {
page.on('download', dl => {
dl.path().then(res);
});
});
await page.setContent(`<a href="${server.PREFIX}/download">download</a>`);
await page.click('a');
const path = await onDownloadPathPath;
expect(fs.readFileSync(path).toString()).toBe('Hello world');
await page.close();
})
it.skip(FFOX).fail(CHROMIUM || WEBKIT)('should report alt-click downloads', async({browser, server}) => { it.skip(FFOX).fail(CHROMIUM || WEBKIT)('should report alt-click downloads', async({browser, server}) => {
// Firefox does not download on alt-click by default. // Firefox does not download on alt-click by default.
// Our WebKit embedder does not download on alt-click, although Safari does. // Our WebKit embedder does not download on alt-click, although Safari does.