From 53d341be017e9a7fbcb702541050251737229e52 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Fri, 17 Mar 2023 16:15:20 +0100 Subject: [PATCH] test: do not pollute stderr with trace-viewer wsEndpoint (#21748) --- packages/playwright-core/src/server/trace/viewer/traceViewer.ts | 2 +- tests/playwright-test/ui-mode-fixtures.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/playwright-core/src/server/trace/viewer/traceViewer.ts b/packages/playwright-core/src/server/trace/viewer/traceViewer.ts index b6724ee9a1..67bbf264ae 100644 --- a/packages/playwright-core/src/server/trace/viewer/traceViewer.ts +++ b/packages/playwright-core/src/server/trace/viewer/traceViewer.ts @@ -99,7 +99,7 @@ export async function showTraceViewer(traceUrls: string[], browserName: string, await context.extendInjectedScript(consoleApiSource.source); const [page] = context.pages(); - if (isUnderTest()) + if (process.env.PWTEST_PRINT_WS_ENDPOINT) process.stderr.write('DevTools listening on: ' + context._browser.options.wsEndpoint + '\n'); if (traceViewerBrowser === 'chromium') diff --git a/tests/playwright-test/ui-mode-fixtures.ts b/tests/playwright-test/ui-mode-fixtures.ts index f0d19dedb3..13cf88b6c3 100644 --- a/tests/playwright-test/ui-mode-fixtures.ts +++ b/tests/playwright-test/ui-mode-fixtures.ts @@ -82,6 +82,7 @@ export const test = base PWTEST_UNDER_TEST: '1', PWTEST_CACHE_DIR: cacheDir, PWTEST_HEADED_FOR_TEST: headless ? '0' : '1', + PWTEST_PRINT_WS_ENDPOINT: '1', }, cwd: options.cwd ? path.resolve(baseDir, options.cwd) : baseDir, });