From 53e274102299c545927457fb3c402cb5bfe0e163 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Viktor=20Sz=C3=A9pe?= Date: Wed, 8 May 2024 17:57:30 +0000 Subject: [PATCH] Revert tests/assets/wpt/ and browser_patches/ --- .../firefox/juggler/content/main.js | 2 +- .../firefox/juggler/protocol/PageHandler.js | 2 +- .../firefox/patches/bootstrap.diff | 12 +++---- .../embedder/Playwright/win/DialogHelper.h | 4 +-- tests/assets/wpt/accname/name/comp_label.html | 32 +++++++++---------- .../accname/name/comp_name_from_content.html | 10 +++--- 6 files changed, 31 insertions(+), 31 deletions(-) diff --git a/browser_patches/firefox/juggler/content/main.js b/browser_patches/firefox/juggler/content/main.js index e0c4f7e91a..022b1e3a5e 100644 --- a/browser_patches/firefox/juggler/content/main.js +++ b/browser_patches/firefox/juggler/content/main.js @@ -106,7 +106,7 @@ function initialize(browsingContext, docShell, actor) { }, ensurePermissions() { - // noop, just a roundtrip. + // noop, just a rountrip. }, hasFailedToOverrideTimezone() { diff --git a/browser_patches/firefox/juggler/protocol/PageHandler.js b/browser_patches/firefox/juggler/protocol/PageHandler.js index a1e908b939..a893e1593b 100644 --- a/browser_patches/firefox/juggler/protocol/PageHandler.js +++ b/browser_patches/firefox/juggler/protocol/PageHandler.js @@ -318,7 +318,7 @@ class PageHandler { const rect = new DOMRect(clip.x, clip.y, clip.width, clip.height); const browsingContext = this._pageTarget.linkedBrowser().browsingContext; - // `win.devicePixelRatio` returns a non-overridden value to privileged code. + // `win.devicePixelRatio` returns a non-overriden value to priveleged code. // See https://bugzilla.mozilla.org/show_bug.cgi?id=1761032 // See https://phabricator.services.mozilla.com/D141323 const devicePixelRatio = browsingContext.overrideDPPX || this._pageTarget._window.devicePixelRatio; diff --git a/browser_patches/firefox/patches/bootstrap.diff b/browser_patches/firefox/patches/bootstrap.diff index 98b927a0de..9de655e886 100644 --- a/browser_patches/firefox/patches/bootstrap.diff +++ b/browser_patches/firefox/patches/bootstrap.diff @@ -1248,7 +1248,7 @@ index 11ca350f483458ba11f0ee170ce38e9785e8c70f..6bb310f6e96239388b4c92bd7bdf2d69 + ScrollAxis(WhereToScroll::Center, WhenToScroll::IfNotFullyVisible), + ScrollFlags::ScrollOverflowHidden); + // If a _visual_ scroll update is pending, cancel it; otherwise, it will -+ // clobber next scroll (e.g. subsequent window.scrollTo(0, 0) will break). ++ // clobber next scroll (e.g. subsequent window.scrollTo(0, 0) wlll break). + if (presShell->GetPendingVisualScrollUpdate()) { + presShell->AcknowledgePendingVisualScrollUpdate(); + presShell->ClearPendingVisualScrollUpdate(); @@ -2722,11 +2722,11 @@ index 4573e28470c5112f5ac2c5dd53e7a9d1ceedb943..b53b86d8e39f1de4b0d0f1a8d5d7295e + nsCOMPtr fileToUse; + rv = interceptor->InterceptDownloadRequest(this, request, mBrowsingContext, getter_AddRefs(fileToUse), &isIntercepted); + if (!NS_SUCCEEDED(rv)) { -+ LOG((" failed to call nsIDownloadInterceptor.interceptDownloadRequest")); ++ LOG((" failed to call nsIDowloadInterceptor.interceptDownloadRequest")); + return rv; + } + if (isIntercepted) { -+ LOG((" request interceped by nsIDownloadInterceptor")); ++ LOG((" request interceped by nsIDowloadInterceptor")); + if (fileToUse) { + mTempFile = fileToUse; + rv = mTempFile->GetLeafName(mTempLeafName); @@ -2768,7 +2768,7 @@ index 4573e28470c5112f5ac2c5dd53e7a9d1ceedb943..b53b86d8e39f1de4b0d0f1a8d5d7295e + if (interceptor) { + nsCString noError; + nsresult rv = interceptor->OnDownloadComplete(this, noError); -+ MOZ_ASSERT(NS_SUCCEEDED(rv), "Failed to call nsIDownloadInterceptor.OnDownloadComplete"); ++ MOZ_ASSERT(NS_SUCCEEDED(rv), "Failed to call nsIDowloadInterceptor.OnDownloadComplete"); + Unused << rv; + } + } @@ -2785,7 +2785,7 @@ index 4573e28470c5112f5ac2c5dd53e7a9d1ceedb943..b53b86d8e39f1de4b0d0f1a8d5d7295e + nsCString errorName; + GetErrorName(aReason, errorName); + nsresult rv = interceptor->OnDownloadComplete(this, errorName); -+ MOZ_ASSERT(NS_SUCCEEDED(rv), "Failed notify nsIDownloadInterceptor about cancel"); ++ MOZ_ASSERT(NS_SUCCEEDED(rv), "Failed notify nsIDowloadInterceptor about cancel"); + Unused << rv; + } + @@ -2978,7 +2978,7 @@ index e4bdf715e2fb899e97a5bfeb2e147127460d6047..3554f919480278b7353617481c7ce805 !aEvent.IsShift() ? ToObjcSelectorPtr(@selector(moveToBeginningOfDocument:)) : ToObjcSelectorPtr( -- @selector(moveToBeginningOfDocumentAndModifySelection:)), +- @selector(moveToBegginingOfDocumentAndModifySelection:)), + @selector(moveToBeginningOfDocumentAndModifySelection:)), aCommands); break; diff --git a/browser_patches/webkit/embedder/Playwright/win/DialogHelper.h b/browser_patches/webkit/embedder/Playwright/win/DialogHelper.h index eb98f2c716..6590fe0025 100644 --- a/browser_patches/webkit/embedder/Playwright/win/DialogHelper.h +++ b/browser_patches/webkit/embedder/Playwright/win/DialogHelper.h @@ -33,11 +33,11 @@ class Dialog { public: bool run(HINSTANCE hInst, HWND hwnd, int dialogId) { - auto result = DialogBoxParam(hInst, MAKEINTRESOURCE(dialogId), hwnd, dialogProc, reinterpret_cast(this)); + auto result = DialogBoxParam(hInst, MAKEINTRESOURCE(dialogId), hwnd, doalogProc, reinterpret_cast(this)); return (result > 0); } - static INT_PTR CALLBACK dialogProc(HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam) + static INT_PTR CALLBACK doalogProc(HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam) { if (message == WM_INITDIALOG) SetWindowLongPtr(hDlg, DWLP_USER, lParam); diff --git a/tests/assets/wpt/accname/name/comp_label.html b/tests/assets/wpt/accname/name/comp_label.html index c9a420d11b..373940c04d 100644 --- a/tests/assets/wpt/accname/name/comp_label.html +++ b/tests/assets/wpt/accname/name/comp_label.html @@ -157,15 +157,15 @@

Name computation precedence tests

- - - - -x + +x label - + - -alt + +alt - + circle - + - - + + - -

x

+ +

x

- - + +

Empty/whitespace aria-label tests

+

heading with link referencing image using aria-labelledby, that in turn references text element via aria-labelledby

link - + image

- +

heading with link referencing image using aria-labelledby, that in turn references itself and another element via aria-labelledby

link - + image

- +

simple w/ for each child (w/o spaces and display:inline)